From fea454753efc4a673751131960c394254555d34a Mon Sep 17 00:00:00 2001 From: Steve Kemp Date: Mon, 9 Mar 2015 13:10:32 +0000 Subject: Don't use parenthesis aroudn conditions in an if. --- lib/custodian/protocoltest/ldap.rb | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'lib/custodian/protocoltest/ldap.rb') diff --git a/lib/custodian/protocoltest/ldap.rb b/lib/custodian/protocoltest/ldap.rb index 56203b2..ba8b442 100644 --- a/lib/custodian/protocoltest/ldap.rb +++ b/lib/custodian/protocoltest/ldap.rb @@ -39,24 +39,24 @@ module Custodian @ldap_user = nil @ldap_pass = nil - if ( line =~ /with\s+username\s+'([^']+)'/ ) + if line =~ /with\s+username\s+'([^']+)'/ @ldap_user = $1.dup end - if ( line =~ /with\s+password\s+'([^']+)'/ ) + if line =~ /with\s+password\s+'([^']+)'/ @ldap_pass = $1.dup end - if ( @ldap_user.nil? ) + if @ldap_user.nil? raise ArgumentError, "No username specified: #{@line}" end - if ( @ldap_pass.nil? ) + if @ldap_pass.nil? raise ArgumentError, "No password specified: #{@line}" end # # Is this test inverted? # - if ( line =~ /must\s+not\s+run\s+/ ) + if line =~ /must\s+not\s+run\s+/ @inverted = true else @inverted = false @@ -65,7 +65,7 @@ module Custodian # # Save the port # - if ( line =~ /on\s+([0-9]+)/ ) + if line =~ /on\s+([0-9]+)/ @port = $1.dup.to_i else @port = 389 @@ -112,7 +112,7 @@ module Custodian # Bind. ldap.bind( @ldap_user, @ldap_pass ) - if ( ldap.bound? ) + if ldap.bound? # # Search -- cgit v1.2.1