From fea454753efc4a673751131960c394254555d34a Mon Sep 17 00:00:00 2001 From: Steve Kemp Date: Mon, 9 Mar 2015 13:10:32 +0000 Subject: Don't use parenthesis aroudn conditions in an if. --- lib/custodian/util/ping.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'lib/custodian/util/ping.rb') diff --git a/lib/custodian/util/ping.rb b/lib/custodian/util/ping.rb index 9abc746..4056803 100644 --- a/lib/custodian/util/ping.rb +++ b/lib/custodian/util/ping.rb @@ -26,7 +26,7 @@ module Custodian # def initialize( hostname ) - raise ArgumentError, "Hostname must not be nil" if ( hostname.nil? ) + raise ArgumentError, "Hostname must not be nil" if hostname.nil? raise ArgumentError, "Hostname must be a String" unless hostname.kind_of?( String ) @hostname = hostname @@ -47,7 +47,7 @@ module Custodian # Does the hostname resolve to an IPv4 address? # def is_ipv4? - if ( ( ! @resolved.nil? ) && ( @resolved =~ /^([0-9]+).([0-9]+).([0-9]+).([0-9]+)$/ ) ) + if ( ! @resolved.nil? ) && ( @resolved =~ /^([0-9]+).([0-9]+).([0-9]+).([0-9]+)$/ ) true else false @@ -59,7 +59,7 @@ module Custodian # Does the hostname resolve to an IPv6 address? # def is_ipv6? - if ( ( ! @resolved.nil? ) && ( @resolved =~ /^([a-f0-9:]+)$/i ) ) + if ( ! @resolved.nil? ) && ( @resolved =~ /^([a-f0-9:]+)$/i ) true else false @@ -74,7 +74,7 @@ module Custodian # Return false on error. # def run_ping - if ( is_ipv6? ) + if is_ipv6? if ( system( "ping6 -c 1 #{@resolved} 2>/dev/null >/dev/null" ) == true ) return true end -- cgit v1.2.1