From ff4eaaebf749e6b91ea0ef96c3eaa36776e9a4b5 Mon Sep 17 00:00:00 2001
From: Wild Kat <wk@users.noreply.github.com>
Date: Sun, 3 Jun 2018 20:51:00 +0200
Subject: bump rubocop to 0.56 and introduce PR template (#1361)

* introduce PR template in lieu of contribution guide for now

* bump rubocop to 0.56 and regenerate rubocop_todo
---
 .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++++++++
 .rubocop_todo.yml                | 24 +++++++++++++++---------
 oxidized.gemspec                 |  2 +-
 3 files changed, 28 insertions(+), 10 deletions(-)
 create mode 100644 .github/PULL_REQUEST_TEMPLATE.md

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 0000000..869b4a9
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,12 @@
+## Pre-Request Checklist
+<!-- Not all items apply to each PR, but a great PR addresses all applicable items. -->
+
+- [ ] Passes rubocop code analysis (try `rubocop --auto-correct`)
+- [ ] Tests added or adapted (try `rake test`)
+- [ ] Changes are reflected in the documentation
+- [ ] User-visible changes appended to [CHANGELOG.md](/CHANGELOG.md)
+
+## Description
+<!-- Describe your changes here. -->
+
+<!-- Add a text similar to "Closes issue #" if this PR relates to an existing issue. -->
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index c6a5e0d..9db8d56 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-06-03 10:03:33 +0200 using RuboCop version 0.55.0.
+# on 2018-06-03 20:42:10 +0200 using RuboCop version 0.56.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -19,7 +19,7 @@ Lint/AmbiguousBlockAssociation:
     - 'lib/oxidized/model/model.rb'
     - 'lib/oxidized/model/nos.rb'
 
-# Offense count: 681
+# Offense count: 683
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
@@ -115,7 +115,7 @@ Lint/Void:
   Exclude:
     - 'lib/oxidized/model/voss.rb'
 
-# Offense count: 63
+# Offense count: 64
 Metrics/AbcSize:
   Max: 84
 
@@ -138,7 +138,7 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 28
 
-# Offense count: 56
+# Offense count: 55
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 76
@@ -206,6 +206,12 @@ Performance/Casecmp:
   Exclude:
     - 'lib/oxidized/manager.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/InefficientHashSearch:
+  Exclude:
+    - 'lib/oxidized/node.rb'
+
 # Offense count: 57
 # Cop supports --auto-correct.
 Performance/RedundantMatch:
@@ -337,7 +343,7 @@ Style/ConditionalAssignment:
     - 'lib/oxidized/hook/githubrepo.rb'
     - 'lib/oxidized/model/model.rb'
 
-# Offense count: 150
+# Offense count: 153
 Style/Documentation:
   Enabled: false
 
@@ -412,7 +418,7 @@ Style/LineEndConcatenation:
   Exclude:
     - 'lib/oxidized/hook.rb'
 
-# Offense count: 137
+# Offense count: 141
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
@@ -503,7 +509,7 @@ Style/ParallelAssignment:
 
 # Offense count: 4
 # Cop supports --auto-correct.
-# Configuration parameters: AllowSafeAssignment.
+# Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
 Style/ParenthesesAroundCondition:
   Exclude:
     - 'lib/oxidized/model/ios.rb'
@@ -707,8 +713,8 @@ Style/ZeroLengthPredicate:
     - 'lib/oxidized/model/ciscosmb.rb'
     - 'lib/oxidized/output/git.rb'
 
-# Offense count: 300
+# Offense count: 302
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
-  Max: 283
+  Max: 193
diff --git a/oxidized.gemspec b/oxidized.gemspec
index 8a126bb..9202335 100644
--- a/oxidized.gemspec
+++ b/oxidized.gemspec
@@ -39,5 +39,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'pry',      '~> 0'
   s.add_development_dependency 'rails_best_practices', '~> 1.19'
   s.add_development_dependency 'rake',     '~> 10.0'
-  s.add_development_dependency 'rubocop',  '~> 0.55.0'
+  s.add_development_dependency 'rubocop',  '~> 0.56.0'
 end
-- 
cgit v1.2.1