From 60c3408bfc0f6aa5a89013f99e0763719440f29b Mon Sep 17 00:00:00 2001 From: Saku Ytti Date: Wed, 25 Apr 2018 19:09:40 +0300 Subject: set version from git you still need to bump version.rb, as 'rake tag' will use that to create git tag, which we need :> --- lib/oxidized/version.rb | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'lib/oxidized/version.rb') diff --git a/lib/oxidized/version.rb b/lib/oxidized/version.rb index 9a92133..0d90e34 100644 --- a/lib/oxidized/version.rb +++ b/lib/oxidized/version.rb @@ -1,3 +1,14 @@ module Oxidized VERSION = '0.21.0' + VERSION_FULL = '0.21.0-175-gcc22060' + def self.version_set + Oxidized.send(:remove_const, :VERSION_FULL) + const_set(:VERSION_FULL, %x(git describe --tags).chop) + Oxidized.send(:remove_const, :VERSION) + const_set(:VERSION, %x(git describe --tags --abbrev=0).chop) + file = File.readlines(__FILE__) + file[1] = " VERSION = '%s'\n" % VERSION + file[2] = " VERSION_FULL = '%s'\n" % VERSION_FULL + File.write(__FILE__, file.join) + end end -- cgit v1.2.3 From 9b22dfeebd5d5f30a8e15be28a00ff84534e9998 Mon Sep 17 00:00:00 2001 From: Saku Ytti Date: Wed, 25 Apr 2018 21:14:40 +0300 Subject: only set version when building packege --- Rakefile | 7 +++++++ lib/oxidized/version.rb | 2 +- oxidized.gemspec | 1 - 3 files changed, 8 insertions(+), 2 deletions(-) (limited to 'lib/oxidized/version.rb') diff --git a/Rakefile b/Rakefile index 6f792d5..25948a2 100644 --- a/Rakefile +++ b/Rakefile @@ -1,5 +1,6 @@ require 'bundler/gem_tasks' require 'rake/testtask' +require_relative 'lib/oxidized/version' gemspec = eval(File.read(Dir['*.gemspec'].first)) file = [gemspec.name, gemspec.version].join('-') + '.gem' @@ -31,6 +32,12 @@ task :test do end end +task :build => :version_set +task :version_set do + Oxidized.version_set + Bundler::GemHelper.instance.gemspec.version = Oxidized::VERSION +end + ## desc 'Install gem' ## task :install => :build do ## system "sudo -Es sh -c \'umask 022; gem install gems/#{file}\'" diff --git a/lib/oxidized/version.rb b/lib/oxidized/version.rb index 0d90e34..de99d5f 100644 --- a/lib/oxidized/version.rb +++ b/lib/oxidized/version.rb @@ -1,6 +1,6 @@ module Oxidized VERSION = '0.21.0' - VERSION_FULL = '0.21.0-175-gcc22060' + VERSION_FULL = '0.21.0-180-g9691008' def self.version_set Oxidized.send(:remove_const, :VERSION_FULL) const_set(:VERSION_FULL, %x(git describe --tags).chop) diff --git a/oxidized.gemspec b/oxidized.gemspec index bf90d00..8a126bb 100644 --- a/oxidized.gemspec +++ b/oxidized.gemspec @@ -1,7 +1,6 @@ lib = File.expand_path('lib', __dir__) $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) require 'oxidized/version' -Oxidized.version_set Gem::Specification.new do |s| s.name = 'oxidized' -- cgit v1.2.3 From 377faa395d79c485ce9dfea6a0483067684d8ada Mon Sep 17 00:00:00 2001 From: Saku Ytti Date: Thu, 26 Apr 2018 00:26:27 +0300 Subject: safe guard version for environment without git --- lib/oxidized/version.rb | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) (limited to 'lib/oxidized/version.rb') diff --git a/lib/oxidized/version.rb b/lib/oxidized/version.rb index de99d5f..a5422fd 100644 --- a/lib/oxidized/version.rb +++ b/lib/oxidized/version.rb @@ -2,13 +2,17 @@ module Oxidized VERSION = '0.21.0' VERSION_FULL = '0.21.0-180-g9691008' def self.version_set - Oxidized.send(:remove_const, :VERSION_FULL) - const_set(:VERSION_FULL, %x(git describe --tags).chop) - Oxidized.send(:remove_const, :VERSION) - const_set(:VERSION, %x(git describe --tags --abbrev=0).chop) - file = File.readlines(__FILE__) - file[1] = " VERSION = '%s'\n" % VERSION - file[2] = " VERSION_FULL = '%s'\n" % VERSION_FULL - File.write(__FILE__, file.join) + version_full = %x(git describe --tags).chop rescue "" + version = %x(git describe --tags --abbrev=0).chop rescue "" + if [version, version_full].none? &:empty? + Oxidized.send(:remove_const, :VERSION) + Oxidized.send(:remove_const, :VERSION_FULL) + const_set(:VERSION, version) + const_set(:VERSION_FULL, version_full) + file = File.readlines(__FILE__) + file[1] = " VERSION = '%s'\n" % VERSION + file[2] = " VERSION_FULL = '%s'\n" % VERSION_FULL + File.write(__FILE__, file.join) + end end end -- cgit v1.2.3 From ce155146656ee8b5f06a175f793a9461c05134ee Mon Sep 17 00:00:00 2001 From: Saku Ytti Date: Thu, 26 Apr 2018 00:31:21 +0300 Subject: fix rubocop being anal --- lib/oxidized/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/oxidized/version.rb') diff --git a/lib/oxidized/version.rb b/lib/oxidized/version.rb index a5422fd..1ca2f55 100644 --- a/lib/oxidized/version.rb +++ b/lib/oxidized/version.rb @@ -4,7 +4,7 @@ module Oxidized def self.version_set version_full = %x(git describe --tags).chop rescue "" version = %x(git describe --tags --abbrev=0).chop rescue "" - if [version, version_full].none? &:empty? + if [version, version_full].none?(&:empty?) Oxidized.send(:remove_const, :VERSION) Oxidized.send(:remove_const, :VERSION_FULL) const_set(:VERSION, version) -- cgit v1.2.3 From f27a0762b0effecbbc64c1e9e221aab6ebba38b2 Mon Sep 17 00:00:00 2001 From: Saku Ytti Date: Thu, 26 Apr 2018 00:40:07 +0300 Subject: praise be --- .rubocop.yml | 3 +++ lib/oxidized/version.rb | 21 +++++++++++---------- 2 files changed, 14 insertions(+), 10 deletions(-) (limited to 'lib/oxidized/version.rb') diff --git a/.rubocop.yml b/.rubocop.yml index 60b4e11..20567f4 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -27,6 +27,9 @@ Style/FormatString: Style/FormatStringToken: EnforcedStyle: unannotated +Style/RescueModifier: + Enabled: false + # Do not attempt to police vendored code, and exclude special cases AllCops: Exclude: diff --git a/lib/oxidized/version.rb b/lib/oxidized/version.rb index 1ca2f55..b607e12 100644 --- a/lib/oxidized/version.rb +++ b/lib/oxidized/version.rb @@ -4,15 +4,16 @@ module Oxidized def self.version_set version_full = %x(git describe --tags).chop rescue "" version = %x(git describe --tags --abbrev=0).chop rescue "" - if [version, version_full].none?(&:empty?) - Oxidized.send(:remove_const, :VERSION) - Oxidized.send(:remove_const, :VERSION_FULL) - const_set(:VERSION, version) - const_set(:VERSION_FULL, version_full) - file = File.readlines(__FILE__) - file[1] = " VERSION = '%s'\n" % VERSION - file[2] = " VERSION_FULL = '%s'\n" % VERSION_FULL - File.write(__FILE__, file.join) - end + + return false unless [version, version_full].none?(&:empty?) + + Oxidized.send(:remove_const, :VERSION) + Oxidized.send(:remove_const, :VERSION_FULL) + const_set(:VERSION, version) + const_set(:VERSION_FULL, version_full) + file = File.readlines(__FILE__) + file[1] = " VERSION = '%s'\n" % VERSION + file[2] = " VERSION_FULL = '%s'\n" % VERSION_FULL + File.write(__FILE__, file.join) end end -- cgit v1.2.3