diff options
author | Patrick J Cherry <patrick@bytemark.co.uk> | 2015-02-17 21:04:52 +0000 |
---|---|---|
committer | Patrick J Cherry <patrick@bytemark.co.uk> | 2015-02-17 21:04:52 +0000 |
commit | 81aead2752316c187255d6732dcb14a46b9c4f05 (patch) | |
tree | ffbce8e2adc99b8093dc7b7a09e159023a7219e2 | |
parent | ec243bb811313ac38fec1ac7ee4e3eb33b92834f (diff) |
fix the redis queue not to melt the cpu when polling redis for a job
-rw-r--r-- | lib/custodian/queue.rb | 21 |
1 files changed, 18 insertions, 3 deletions
diff --git a/lib/custodian/queue.rb b/lib/custodian/queue.rb index 67c5346..9a7d90f 100644 --- a/lib/custodian/queue.rb +++ b/lib/custodian/queue.rb @@ -85,13 +85,28 @@ end # - # Fetch a job from the queue - the timeout parameter is ignored. + # Fetch a job from the queue. + # + # The timeout is used to specify the period we wait for a new job. # def fetch(timeout) - job = false - while( ! job ) + job = nil + timeout ||= 0 + + # + # Don't melt the CPU. + # + sleep_interval = 0.5 + + loop do job = @redis.lpop( "queue" ) + break if job or timeout < 0 + + sleep( sleep_interval ) + + timeout -= sleep_interval end + return( job ) end |