Significant rubocop fixups.

This merge-request contains almost entirely mechanical changes,
with a few exceptions:

* I changed `do_ipv4` and `do_ipv6` to `ipv4` and `ipv6` respectively.
  * This fixed a warning about normal-casing.
* I changed a test-case to compare against both `Integer` and `Fixnum`
  * Suspect this is a ruby-versionism.

The tests continue to pass, so I believe this is safe to merge,
but of course it is still not 100%:

    lib/custodian/queue.rb:135:21: W: Assignment in condition - you probably meant to use ==.
              added = true
                    ^
    lib/custodian/protocoltest/ssl.rb:218:5: W: Do not shadow rescued Exceptions
        rescue OpenSSL::SSL::SSLError => err ...
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    lib/custodian/protocoltest/ssl.rb:286:5: W: Do not shadow rescued Exceptions
        rescue OpenSSL::SSL::SSLError => err ...
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    lib/custodian/protocoltest/http.rb:307:7: C: Assignment Branch Condition size for run_test is too high. [84.53/72]
          def run_test
          ^^^
    lib/custodian/protocoltest/http.rb:307:7: C: Cyclomatic complexity for run_test is too high. [22/19]
          def run_test
          ^^^
    lib/custodian/protocoltest/http.rb:307:7: C: Method has too many lines. [97/87]
          def run_test ...
          ^^^^^^^^^^^^
    lib/custodian/protocoltest/http.rb:307:7: C: Perceived complexity for run_test is too high. [23/21]
          def run_test

In short this takes care of _most_ of the warnings, but updates requiring
significant code-change have not been applied.

1 files changed, 2 insertions, 1 deletions

diff --git a/bin/multi-ping b/bin/multi-ping
index 6d905bb..1045635 100755
--- a/bin/multi-ping
+++ b/bin/multi-ping
@@ -14,7 +14,8 @@ manual = false
 
 opts = GetoptLong.new(
   ['--help',   '-h', GetoptLong::NO_ARGUMENT],
-  ['--manual', '-m', GetoptLong::NO_ARGUMENT])
+  ['--manual', '-m', GetoptLong::NO_ARGUMENT]
+)
 
 begin
   opts.each do |opt, _arg|