diff options
author | Steve Kemp <steve@steve.org.uk> | 2015-03-09 13:10:32 +0000 |
---|---|---|
committer | Steve Kemp <steve@steve.org.uk> | 2015-03-09 13:10:32 +0000 |
commit | fea454753efc4a673751131960c394254555d34a (patch) | |
tree | 47732a1c331c236f8f082dc4f6f5a6c6d6dab058 /lib/custodian/testfactory.rb | |
parent | edf0e675123e4869e2739d1bab0ed57b3b9f664c (diff) |
Don't use parenthesis aroudn conditions in an if.
Diffstat (limited to 'lib/custodian/testfactory.rb')
-rw-r--r-- | lib/custodian/testfactory.rb | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/lib/custodian/testfactory.rb b/lib/custodian/testfactory.rb index 03222a2..748e114 100644 --- a/lib/custodian/testfactory.rb +++ b/lib/custodian/testfactory.rb @@ -31,8 +31,8 @@ module Custodian def self.create( line ) - raise ArgumentError, "The type of test to create cannot be nil" if ( line.nil? ) - raise ArgumentError, "The type of test to create must be a string" unless ( line.kind_of? String ) + raise ArgumentError, "The type of test to create cannot be nil" if line.nil? + raise ArgumentError, "The type of test to create must be a string" unless line.kind_of? String # # The array we return. @@ -43,12 +43,12 @@ module Custodian # # If this is an obvious protocol test. # - if ( line =~ /must\s+(not\s+)?run\s+(\S+)(\s+|\.|$)/ ) + if line =~ /must\s+(not\s+)?run\s+(\S+)(\s+|\.|$)/ test_type = $2.dup test_type.chomp!( "." ) - if ( @@subclasses[test_type].nil? ) + if @@subclasses[test_type].nil? raise ArgumentError, "There is no handler registered for the '#{test_type}' test-type" end @@ -66,7 +66,7 @@ module Custodian # # We do this only after we've instantiated the test. # - if ( line =~ /\s+otherwise\s+'([^']+)'/ ) + if line =~ /\s+otherwise\s+'([^']+)'/ obj.set_notification_text( $1.dup ) end |