summaryrefslogtreecommitdiff
path: root/lib/custodian/worker.rb
diff options
context:
space:
mode:
authorSteve Kemp <steve@steve.org.uk>2015-03-09 13:10:32 +0000
committerSteve Kemp <steve@steve.org.uk>2015-03-09 13:10:32 +0000
commit1ce0906b3480702085d4596dbb4758c115ab298f (patch)
tree695cd365c2ff73904328a049f3b9cfcc5a0a1abd /lib/custodian/worker.rb
parent891b720013f06f092f6be82adad95e5551c696b6 (diff)
Don't use parenthesis aroudn conditions in an if.
Diffstat (limited to 'lib/custodian/worker.rb')
-rw-r--r--lib/custodian/worker.rb16
1 files changed, 8 insertions, 8 deletions
diff --git a/lib/custodian/worker.rb b/lib/custodian/worker.rb
index fd1abce..2c806fd 100644
--- a/lib/custodian/worker.rb
+++ b/lib/custodian/worker.rb
@@ -93,7 +93,7 @@ module Custodian
# Show a message on STDOUT if "--verbose" was specified.
#
def log_message( msg )
- puts msg if ( ENV["VERBOSE" ] )
+ puts msg if ENV["VERBOSE" ]
end
@@ -125,7 +125,7 @@ module Custodian
#
# Ensure that the job is sane.
#
- raise ArgumentError, "Job was empty" if (job.nil?)
+ raise ArgumentError, "Job was empty" if job.nil?
raise ArgumentError, "Job was not a string" unless job.kind_of?(String)
#
@@ -162,7 +162,7 @@ module Custodian
#
# We exit here if we receive a single success.
#
- while ( ( count < ( @retry_count + 1 ) ) && ( result == false ) )
+ while ( count < ( @retry_count + 1 ) ) && ( result == false )
log_message( "Running test - [#{count}/#{@retry_count}]" )
@@ -170,9 +170,9 @@ module Custodian
# Run the test - inverting the result if we should
#
result = test.run_test
- result = ! result if ( test.inverted )
+ result = ! result if test.inverted
- if ( result )
+ if result
log_message( "Test succeeed - clearing alert" )
do_clear( test )
end
@@ -186,7 +186,7 @@ module Custodian
# The intention here is that if the test passes then there will
# be no delay. If the test fails then we'll sleep.
#
- if ( ( result == false ) && ( @retry_delay > 0 ) && ( count < @retry_count ) )
+ if ( result == false ) && ( @retry_delay > 0 ) && ( count < @retry_count )
log_message( "Sleeping for #{@retry_delay} seconds to allow cool-down" )
sleep( @retry_delay )
end
@@ -218,7 +218,7 @@ module Custodian
#
# If we didn't succeed on any of the attempts raise the alert.
#
- if ( ! result )
+ if ! result
#
# Raise the alert, passing the error message.
@@ -291,7 +291,7 @@ module Custodian
# give the alerter a reference to the settings object.
alert.set_settings( @settings )
- alert.duration( duration ) if ( alert.respond_to? "duration" )
+ alert.duration( duration ) if alert.respond_to? "duration"
end
end