summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorSteve Kemp <steve@steve.org.uk>2015-03-09 12:54:51 +0000
committerSteve Kemp <steve@steve.org.uk>2015-03-09 12:54:51 +0000
commit43959bccde198171cee796fdfbd82ae5a75a4378 (patch)
tree8bcc5e71787035d572ff7458220531a28cd2786e /lib
parent881ead73eca30cc11c885811276cd5310fe1e418 (diff)
Avoid arguments we're not using.
Having methods take arguments which are ignored is a misleading thing, prefix with "_" to make that explicit, or remove.
Diffstat (limited to 'lib')
-rw-r--r--lib/custodian/alerts/redis-state.rb13
-rw-r--r--lib/custodian/queue.rb4
2 files changed, 2 insertions, 15 deletions
diff --git a/lib/custodian/alerts/redis-state.rb b/lib/custodian/alerts/redis-state.rb
index 03b31fa..7d9daa7 100644
--- a/lib/custodian/alerts/redis-state.rb
+++ b/lib/custodian/alerts/redis-state.rb
@@ -91,19 +91,6 @@ module Custodian
@redis.ltrim( "recent-tests", 0, 100 )
end
-
-
- #
- # Store a test-duration in redis
- #
- def duration( ms )
-
- return unless( @redis )
-
- # NOP
- end
-
-
register_alert_type "redis"
end
diff --git a/lib/custodian/queue.rb b/lib/custodian/queue.rb
index 1bdbee2..e8cfb8a 100644
--- a/lib/custodian/queue.rb
+++ b/lib/custodian/queue.rb
@@ -38,7 +38,7 @@ module Custodian
#
# Retrieve a job from the queue.
#
- def fetch(timeout)
+ def fetch(_timeout)
raise "Subclasses must implement this method!"
end
@@ -46,7 +46,7 @@ module Custodian
#
# Add a new job to the queue.
#
- def add(job_string)
+ def add(_job_string)
raise "Subclasses must implement this method!"
end