diff options
| author | Steve Kemp <steve@steve.org.uk> | 2015-03-09 13:10:32 +0000 |
|---|---|---|
| committer | Steve Kemp <steve@steve.org.uk> | 2015-03-09 13:10:32 +0000 |
| commit | fea454753efc4a673751131960c394254555d34a (patch) | |
| tree | 47732a1c331c236f8f082dc4f6f5a6c6d6dab058 /t | |
| parent | edf0e675123e4869e2739d1bab0ed57b3b9f664c (diff) | |
Don't use parenthesis aroudn conditions in an if.
Diffstat (limited to 't')
| -rwxr-xr-x | t/test-custodian-alertfactory.rb | 4 | ||||
| -rwxr-xr-x | t/test-custodian-parser.rb | 6 | ||||
| -rwxr-xr-x | t/test-custodian-testfactory.rb | 4 | ||||
| -rwxr-xr-x | t/test-custodian-util-bytemark.rb | 2 |
4 files changed, 8 insertions, 8 deletions
diff --git a/t/test-custodian-alertfactory.rb b/t/test-custodian-alertfactory.rb index e12dbdd..42873ec 100755 --- a/t/test-custodian-alertfactory.rb +++ b/t/test-custodian-alertfactory.rb @@ -54,8 +54,8 @@ class TestAlertFactory < Test::Unit::TestCase mauve = false end - methods.push( "redis" ) if ( redis ) - methods.push( "mauve" ) if ( mauve ) + methods.push( "redis" ) if redis + methods.push( "mauve" ) if mauve methods.each do |name| diff --git a/t/test-custodian-parser.rb b/t/test-custodian-parser.rb index 43a0754..bd5205b 100755 --- a/t/test-custodian-parser.rb +++ b/t/test-custodian-parser.rb @@ -305,7 +305,7 @@ EOF assert( obj.size == 1 ) assert_equal( obj[0].to_s, str ) - if ( follow ) + if follow assert( obj[0].follow_redirects? ) else assert( ! obj[0].follow_redirects? ) @@ -344,7 +344,7 @@ EOF assert( obj.size == 1 ) assert_equal( obj[0].to_s, str ) - if ( cb ) + if cb assert( obj[0].cache_busting? ) else assert( ! obj[0].cache_busting? ) @@ -390,7 +390,7 @@ EOF assert( obj.size == 1 ) assert_equal( obj[0].to_s, str ) - if ( fail.nil? ) + if fail.nil? assert( obj[0].get_notification_text.nil? ) else assert_equal( obj[0].get_notification_text, fail ) diff --git a/t/test-custodian-testfactory.rb b/t/test-custodian-testfactory.rb index 6c71003..b067ab8 100755 --- a/t/test-custodian-testfactory.rb +++ b/t/test-custodian-testfactory.rb @@ -255,13 +255,13 @@ class TestTestFactory < Test::Unit::TestCase # for each handler .. registered[type].each do |name| - if ( name.to_s =~ /protocoltest::(.*)Test$/i ) + if name.to_s =~ /protocoltest::(.*)Test$/i tst = $1.dup.downcase # # NOTE: Skip the DNS and LDAP tests - they are more complex. # - next if ( tst =~ /^(ldap|dns|dnsbl|sslcertificate)$/ ) + next if tst =~ /^(ldap|dns|dnsbl|sslcertificate)$/ # normal test_one = "http://foo.com/.com must run #{tst} on 1234" diff --git a/t/test-custodian-util-bytemark.rb b/t/test-custodian-util-bytemark.rb index 764babc..9296dcb 100755 --- a/t/test-custodian-util-bytemark.rb +++ b/t/test-custodian-util-bytemark.rb @@ -52,7 +52,7 @@ class TestBytemarkUtil < Test::Unit::TestCase to_test.each do |name,inside| - if ( inside ) + if inside assert( Custodian::Util::Bytemark.inside?( name ) == true ) else assert( Custodian::Util::Bytemark.inside?( name ) == false ) |