| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2015-04-16 | Mark unused variables as unused. | Steve Kemp | |
| We do that with the standard "_"-prefix. | |||
| 2015-04-16 | Mark variables as unused. | Steve Kemp | |
| We've now prefixed our transient/unused variables with "_" to stop any future errors about variables not being used. | |||
| 2015-04-16 | Correctly initialize our state. | Steve Kemp | |
| We'd failed to set the default value of our loaded-marker to false, although in-practice this wasn't a problem. | |||
| 2015-04-16 | Added tag release-0.24.7 for changeset 2cb078a62f4e | Steve Kemp | |
| 2015-04-16 | Mention the LDAP.rb fixuprelease-0.24.7 | Steve Kemp | |
| 2015-04-16 | Ensure we load our base-class. | Steve Kemp | |
| 2015-04-16 | Fixed to be valid. | Steve Kemp | |
| Due to some sloppy edits this module was not correct. | |||
| 2015-04-16 | Fixed syntax error. | Steve Kemp | |
| 2015-04-16 | Added tag release-0.24.7 for changeset 1368ceed0ca3 | Steve Kemp | |
| 2015-04-16 | New release | Steve Kemp | |
| 2015-04-16 | Correctly use the result of the resolution in the alert. | Steve Kemp | |
| There was a bug in that we used the same local-variable "result" for two purposes, trashing the intended use-case. | |||
| 2015-04-16 | Updated test to pass with new IPs. | Steve Kemp | |
| Hard-coding IPs is a bad choice, but the alternative here is to exec( `dig -t a`) or similar which seems equally bad. | |||
| 2015-04-16 | Resolve hostnames for both A + AAAA. | Steve Kemp | |
| The Bytemark-specific notifier, using mauve, appends some text to the bottom of each alert: http://example.com/ resolves to 1.2.3.4 which is INSIDE|OUTSIDE bytemark This text was previously limited to the IPv4 address, but now is repeated for each family which resolves successfully. This closes #10568. This fixes #10568. | |||
| 2015-03-10 | Log the failure-reason on the temporary-fails. | Steve Kemp | |
| 2015-03-10 | Correctly skip the rubocop testing if the gem is missing. | Steve Kemp | |
| We now use the Test::Unit::TestCase.skip() method if the gem is missing, rather than kill the whole suite. | |||
| 2015-03-10 | Removed this test-case. | Steve Kemp | |
| The method-stubbing doesn't work, and so it is obsolete. | |||
| 2015-03-09 | Added test-case for quiet-rubocop. | Steve Kemp | |
| This is designed to ensure that we meet the style/code guideline defined in `.rubocop.yml`. | |||
| 2015-03-09 | Show error-message clearly on connection-failure. | Steve Kemp | |
| This was failing because '$ERROR_INFO' is only available if you require 'English' | |||
| 2015-03-09 | Updated to test for more whitespace issues. | Steve Kemp | |
| 2015-03-09 | Removed trailing whitespace from the code | Steve Kemp | |
| 2015-03-09 | Moved usage-information to foot of script. | Steve Kemp | |
| This removes the nasty self-parsing of the script to generate the help/manual output. I've also removed global-variables and made the code almost-100% warning free. | |||
| 2015-03-09 | Document rubodoc | Steve Kemp | |
| 2015-03-09 | Record the style/formatting guides we use. | Steve Kemp | |
| These might change in the future, but for the moment the formatting codes are useful to ensure consistent code. | |||
| 2015-03-09 | Remove spaces inside empty hashes | Steve Kemp | |
| 2015-03-09 | Remove spaces inside blocks. | Steve Kemp | |
| 2015-03-09 | Remove spaces before commas. | Steve Kemp | |
| 2015-03-09 | More minor space fixups | Steve Kemp | |
| 2015-03-09 | Whitespace fixups. | Steve Kemp | |
| These were all identified and suggested by rubocop. | |||
| 2015-03-09 | Use def with parentheses when there are parameters. | Steve Kemp | |
| 2015-03-09 | Removed spaces inside parenthesis. | Steve Kemp | |
| 2015-03-09 | Prefer single-quotes when you don't need interpolation. | Steve Kemp | |
| So "foo" is less good than 'foo'. | |||
| 2015-03-09 | Prefer single-quoted strings inside interpolations. | Steve Kemp | |
| 2015-03-09 | Do not terminate expressions with ";". | Steve Kemp | |
| Ruby is not Perl, much as I sometimes wish it were. | |||
| 2015-03-09 | Avoid redudent returns. | Steve Kemp | |
| The last expression of a method is the return value. So: def foo; false ; end Is the same as: def foo; return false; end | |||
| 2015-03-09 | Avoid bogus casing of method-name. | Steve Kemp | |
| So "getURL" becomes "get_url_contents" | |||
| 2015-03-09 | Don't use parenthesis aroudn conditions in an if. | Steve Kemp | |
| 2015-03-09 | Do not use parentheses for method calls with no arguments. | Steve Kemp | |
| This is neater. Flagged by rubocop | |||
| 2015-03-09 | Avoid "Array.new" and "Hash.new" | Steve Kemp | |
| Instead use {} + (). | |||
| 2015-03-09 | Removed bogus period. | Steve Kemp | |
| 2015-03-09 | Omit the parentheses in defs when the method doesn't accept any arguments. | Steve Kemp | |
| This is neater. | |||
| 2015-03-09 | Minor indentation fixup. | Steve Kemp | |
| 2015-03-09 | Don't use "::" for method-calls. | Steve Kemp | |
| Instead prefer ".". Flagged by rubocop | |||
| 2015-03-09 | Added more tests. | Steve Kemp | |
| 2015-03-09 | Avoid arguments we're not using. | Steve Kemp | |
| Having methods take arguments which are ignored is a misleading thing, prefix with "_" to make that explicit, or remove. | |||
| 2015-03-09 | Removed dead code. | Steve Kemp | |
| After raising an exception the following code could not be reached. | |||
| 2015-03-09 | Avoid redundent ".to_s" methods. | Steve Kemp | |
| These are not required if the argument is string already, or has a _to_s method which will be automatically invoked by magic. | |||
| 2015-03-09 | Don't rescue the 'Exception' | Steve Kemp | |
| Instead rescue a 'StandardError' which is slightly more specific. (Rescuing more specific exceptions is good.) | |||
| 2015-03-09 | Avoid useless wrapping of return-value. | Steve Kemp | |
| This: def foo line end Is the same as this: def foo return( line ) end | |||
| 2015-03-09 | File.exists? is deprecated. | Steve Kemp | |
| We prefer "File.exist?". Flagged by rubocop. | |||
| 2015-03-09 | Use long-names | Steve Kemp | |
| Instead of "$0" use $PROGRAM_NAME, instead of $! use "$LOAD_PATH". This is more explicit and less-magic. Flagged by rubocop | |||
 |
index : custodian.git | |
| A distributed protocol tester. |
| summaryrefslogtreecommitdiff |