summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-04-16Mention the LDAP.rb fixupSteve Kemp
2015-04-16Ensure we load our base-class.Steve Kemp
2015-04-16Fixed to be valid.Steve Kemp
Due to some sloppy edits this module was not correct.
2015-04-16Fixed syntax error.Steve Kemp
2015-04-16Added tag release-0.24.7 for changeset 1368ceed0ca3Steve Kemp
2015-04-16New releaseSteve Kemp
2015-04-16Correctly use the result of the resolution in the alert.Steve Kemp
There was a bug in that we used the same local-variable "result" for two purposes, trashing the intended use-case.
2015-04-16Updated test to pass with new IPs.Steve Kemp
Hard-coding IPs is a bad choice, but the alternative here is to exec( `dig -t a`) or similar which seems equally bad.
2015-04-16Resolve hostnames for both A + AAAA.Steve Kemp
The Bytemark-specific notifier, using mauve, appends some text to the bottom of each alert: http://example.com/ resolves to 1.2.3.4 which is INSIDE|OUTSIDE bytemark This text was previously limited to the IPv4 address, but now is repeated for each family which resolves successfully. This closes #10568. This fixes #10568.
2015-03-10Log the failure-reason on the temporary-fails.Steve Kemp
2015-03-10Correctly skip the rubocop testing if the gem is missing.Steve Kemp
We now use the Test::Unit::TestCase.skip() method if the gem is missing, rather than kill the whole suite.
2015-03-10Removed this test-case.Steve Kemp
The method-stubbing doesn't work, and so it is obsolete.
2015-03-09Added test-case for quiet-rubocop.Steve Kemp
This is designed to ensure that we meet the style/code guideline defined in `.rubocop.yml`.
2015-03-09Show error-message clearly on connection-failure.Steve Kemp
This was failing because '$ERROR_INFO' is only available if you require 'English'
2015-03-09Updated to test for more whitespace issues.Steve Kemp
2015-03-09Removed trailing whitespace from the codeSteve Kemp
2015-03-09Moved usage-information to foot of script.Steve Kemp
This removes the nasty self-parsing of the script to generate the help/manual output. I've also removed global-variables and made the code almost-100% warning free.
2015-03-09Document rubodocSteve Kemp
2015-03-09Record the style/formatting guides we use.Steve Kemp
These might change in the future, but for the moment the formatting codes are useful to ensure consistent code.
2015-03-09Remove spaces inside empty hashesSteve Kemp
2015-03-09Remove spaces inside blocks.Steve Kemp
2015-03-09Remove spaces before commas.Steve Kemp
2015-03-09More minor space fixupsSteve Kemp
2015-03-09Whitespace fixups.Steve Kemp
These were all identified and suggested by rubocop.
2015-03-09Use def with parentheses when there are parameters.Steve Kemp
2015-03-09Removed spaces inside parenthesis.Steve Kemp
2015-03-09Prefer single-quotes when you don't need interpolation.Steve Kemp
So "foo" is less good than 'foo'.
2015-03-09 Prefer single-quoted strings inside interpolations.Steve Kemp
2015-03-09Do not terminate expressions with ";".Steve Kemp
Ruby is not Perl, much as I sometimes wish it were.
2015-03-09Avoid redudent returns.Steve Kemp
The last expression of a method is the return value. So: def foo; false ; end Is the same as: def foo; return false; end
2015-03-09Avoid bogus casing of method-name.Steve Kemp
So "getURL" becomes "get_url_contents"
2015-03-09Don't use parenthesis aroudn conditions in an if.Steve Kemp
2015-03-09Do not use parentheses for method calls with no arguments.Steve Kemp
This is neater. Flagged by rubocop
2015-03-09Avoid "Array.new" and "Hash.new"Steve Kemp
Instead use {} + ().
2015-03-09Removed bogus period.Steve Kemp
2015-03-09Omit the parentheses in defs when the method doesn't accept any arguments.Steve Kemp
This is neater.
2015-03-09Minor indentation fixup.Steve Kemp
2015-03-09Don't use "::" for method-calls.Steve Kemp
Instead prefer ".". Flagged by rubocop
2015-03-09Added more tests.Steve Kemp
2015-03-09Avoid arguments we're not using.Steve Kemp
Having methods take arguments which are ignored is a misleading thing, prefix with "_" to make that explicit, or remove.
2015-03-09Removed dead code.Steve Kemp
After raising an exception the following code could not be reached.
2015-03-09Avoid redundent ".to_s" methods.Steve Kemp
These are not required if the argument is string already, or has a _to_s method which will be automatically invoked by magic.
2015-03-09Don't rescue the 'Exception'Steve Kemp
Instead rescue a 'StandardError' which is slightly more specific. (Rescuing more specific exceptions is good.)
2015-03-09Avoid useless wrapping of return-value.Steve Kemp
This: def foo line end Is the same as this: def foo return( line ) end
2015-03-09File.exists? is deprecated.Steve Kemp
We prefer "File.exist?". Flagged by rubocop.
2015-03-09Use long-namesSteve Kemp
Instead of "$0" use $PROGRAM_NAME, instead of $! use "$LOAD_PATH". This is more explicit and less-magic. Flagged by rubocop
2015-03-04Added tag release-0.24.6 for changeset 9c1711d7bf89Steve Kemp
2015-03-04new releaseSteve Kemp
2015-03-04Allow SSL-check to be disabled, via "no_ssl_check"Steve Kemp
2015-03-04Added tag release-0.24.5 for changeset 393c7c751ab1Steve Kemp