| Age | Commit message (Collapse) | Author |
|---|
|
This merge-request contains almost entirely mechanical changes,
with a few exceptions:
* I changed `do_ipv4` and `do_ipv6` to `ipv4` and `ipv6` respectively.
* This fixed a warning about normal-casing.
* I changed a test-case to compare against both `Integer` and `Fixnum`
* Suspect this is a ruby-versionism.
The tests continue to pass, so I believe this is safe to merge,
but of course it is still not 100%:
lib/custodian/queue.rb:135:21: W: Assignment in condition - you probably meant to use ==.
added = true
^
lib/custodian/protocoltest/ssl.rb:218:5: W: Do not shadow rescued Exceptions
rescue OpenSSL::SSL::SSLError => err ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/custodian/protocoltest/ssl.rb:286:5: W: Do not shadow rescued Exceptions
rescue OpenSSL::SSL::SSLError => err ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/custodian/protocoltest/http.rb:307:7: C: Assignment Branch Condition size for run_test is too high. [84.53/72]
def run_test
^^^
lib/custodian/protocoltest/http.rb:307:7: C: Cyclomatic complexity for run_test is too high. [22/19]
def run_test
^^^
lib/custodian/protocoltest/http.rb:307:7: C: Method has too many lines. [97/87]
def run_test ...
^^^^^^^^^^^^
lib/custodian/protocoltest/http.rb:307:7: C: Perceived complexity for run_test is too high. [23/21]
def run_test
In short this takes care of _most_ of the warnings, but updates requiring
significant code-change have not been applied.
|
|
|
|
We now use a zset to store our pending tests. This means that
jobs are only in the queue once - no duplicates are allowed.
This closes #12428.
|
|
The beanstalkd queue used to be used in the past, and we later
added support for Redis via a simple abstraction layer. But now
we've no longer tested and used beanstalkd for over a year, and
the client-libraries are no longer available as native Debian
packages.
With that in mind we've excised the code, although left the
abstraction-class in-place.
|
|
This shouldn't be required, but adding it is harmless and indicates
our intent cleanly.
|
|
This removes the nasty self-parsing of the script to generate the
help/manual output. I've also removed global-variables and made
the code almost-100% warning free.
|
|
|
|
|
|
These were all identified and suggested by rubocop.
|
|
|
|
So "foo" is less good than 'foo'.
|
|
|
|
This is neater. Flagged by rubocop
|
|
These are not required if the argument is string already, or has
a _to_s method which will be automatically invoked by magic.
|
|
Instead of "$0" use $PROGRAM_NAME, instead of $! use "$LOAD_PATH". This
is more explicit and less-magic.
Flagged by rubocop
|
|
|
|
(This mostly means the removal of --logfile.)
|
|
Rather than passing our settings-object around, as well as
specific settings that are read from it, just pass the object.
The worker can read the settings directly if/when it needs to.
|
|
Now that we've moved to using redis by default the handling of queue-flushing
needs to change. We can simply get rid of the busy-wait and run a redis
"del" operation.
With that in mind we've moved the flushing logic to our queue abstraction
layer, and simplified our queue-helper script.
|
|
This allows our redis-library to be used.
|
|
Read it from the configuration-file and don't expose the server
flag which is now bogus.
|
|
This means we can queue/dequeue to either Redis or Beanstalkd.
|
|
This is a temporary fix for local-testing.
|
|
|
|
This allows job.reserve() to keep a job for a "long" time.
|
|
|
|
|
|
|
|
pinged.
|
|
|
|
longer invokes mauvealert directly. Instead the exit code of the
script will be used to report success/failure.
|
|
|
|
not used.
|
|
anything else running under beanstalkd.
|
|
|
|
|
|
|
|
Abort if parsing fails.
|
|
|
|
|
|
filename
if appropriate for logging.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
