| Age | Commit message (Collapse) | Author |
|---|
|
This merge-request contains almost entirely mechanical changes,
with a few exceptions:
* I changed `do_ipv4` and `do_ipv6` to `ipv4` and `ipv6` respectively.
* This fixed a warning about normal-casing.
* I changed a test-case to compare against both `Integer` and `Fixnum`
* Suspect this is a ruby-versionism.
The tests continue to pass, so I believe this is safe to merge,
but of course it is still not 100%:
lib/custodian/queue.rb:135:21: W: Assignment in condition - you probably meant to use ==.
added = true
^
lib/custodian/protocoltest/ssl.rb:218:5: W: Do not shadow rescued Exceptions
rescue OpenSSL::SSL::SSLError => err ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/custodian/protocoltest/ssl.rb:286:5: W: Do not shadow rescued Exceptions
rescue OpenSSL::SSL::SSLError => err ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/custodian/protocoltest/http.rb:307:7: C: Assignment Branch Condition size for run_test is too high. [84.53/72]
def run_test
^^^
lib/custodian/protocoltest/http.rb:307:7: C: Cyclomatic complexity for run_test is too high. [22/19]
def run_test
^^^
lib/custodian/protocoltest/http.rb:307:7: C: Method has too many lines. [97/87]
def run_test ...
^^^^^^^^^^^^
lib/custodian/protocoltest/http.rb:307:7: C: Perceived complexity for run_test is too high. [23/21]
def run_test
In short this takes care of _most_ of the warnings, but updates requiring
significant code-change have not been applied.
|
|
|
|
|
|
|
|
|
|
This will make visualization more simple.
|
|
This stops warnings when running with "ruby -w".
|
|
There was a bug in that we used the same local-variable "result"
for two purposes, trashing the intended use-case.
|
|
The Bytemark-specific notifier, using mauve, appends some text to
the bottom of each alert:
http://example.com/ resolves to 1.2.3.4 which is INSIDE|OUTSIDE bytemark
This text was previously limited to the IPv4 address, but now is repeated
for each family which resolves successfully.
This closes #10568.
This fixes #10568.
|
|
|
|
|
|
These were all identified and suggested by rubocop.
|
|
|
|
So "foo" is less good than 'foo'.
|
|
Ruby is not Perl, much as I sometimes wish it were.
|
|
|
|
This is neater. Flagged by rubocop
|
|
This is neater.
|
|
|
|
Having methods take arguments which are ignored is a misleading thing,
prefix with "_" to make that explicit, or remove.
|
|
This is required under Ruby 1.8, as I discovered when deploying
to offsite3.
|
|
We need to do this such that we can show all possible results
of a test in the status-page. There might be three back-ends
with different results and if we filter by class-type we'll
be able to see that.
|
|
As soon as we allow multiple test-implementations we get
into a mess, as Mauve regards an ID as unique and that is
based upon the test-definition not the implementing method
We want to allow:
* HTTPS test to succeed.
* SSL-check to fail.
Which means multiple tests of type "https" will have different
IDs. Force this by adding on the class of the implementation.
|
|
|
|
|
|
The redis-state "alerter" saves state in a useful way for the
future, and will now save an array of hashes - each has corresponding
to a useful result.
|
|
|
|
We now record:
custodian.$type.$host.test_duration [time]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Credit to reddit user knothead for spotting this bug.
Fixes #4386.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This will mean historically we can see what the failure reason was.
|
|
* Added debian recommendation for mauvealert-client
|
|
|
|
|
|
|
