| Age | Commit message (Collapse) | Author |
|---|
|
Ruby is not Perl, much as I sometimes wish it were.
|
|
The last expression of a method is the return value. So:
def foo; false ; end
Is the same as:
def foo; return false; end
|
|
So "getURL" becomes "get_url_contents"
|
|
|
|
This is neater. Flagged by rubocop
|
|
Instead use {} + ().
|
|
|
|
This is neater.
|
|
|
|
Instead prefer ".".
Flagged by rubocop
|
|
Having methods take arguments which are ignored is a misleading thing,
prefix with "_" to make that explicit, or remove.
|
|
After raising an exception the following code could not be reached.
|
|
These are not required if the argument is string already, or has
a _to_s method which will be automatically invoked by magic.
|
|
Instead rescue a 'StandardError' which is slightly more specific.
(Rescuing more specific exceptions is good.)
|
|
This:
def foo
line
end
Is the same as this:
def foo
return( line )
end
|
|
We prefer "File.exist?".
Flagged by rubocop.
|
|
Instead of "$0" use $PROGRAM_NAME, instead of $! use "$LOAD_PATH". This
is more explicit and less-magic.
Flagged by rubocop
|
|
|
|
|
|
|
|
|
|
|
|
Instead we run quietly if nothing was output, and run verbosely if we
see "--verbose".
|
|
|
|
Via "ipv6_only" and "IPv4_only"
|
|
This is required under Ruby 1.8, as I discovered when deploying
to offsite3.
|
|
|
|
If a target is a hostname we'll explicitly resolve it for
both IPv4 and IPv6.
|
|
THis tests that a server is listening on :53.
|
|
If we're given an IPv4 or IPv6 address then use it, if
not then attempt to resolve the name that we've been
given to one/other/both of these types and test
in turn.
|
|
This is a clone of the code that we're already using for
SSL checking of domains. The biggest excpetion is that I've
disabled the SSL v2/v3 checking because that is causing alerts
on https://google.com/
This closes #9563.
|
|
This allows the test-suite to pass.
|
|
No functional changes.
|
|
Also only sleep between fetches if we couldn't find a job because
the queue was empty.
|
|
|
|
This was an invalid comment, the timeout related to HTTP-fetches.
|
|
|
|
We now parse a single test-definition into multiple
test-implementations. This isn't required here because
the parser only needs to know that the configuration file
*can* be parsed, not what the result is.
Validate that we got an array, but otherwise ignore the
results after the first.
|
|
|
|
This is a stub for the moment, but it validates that we can have
multiple handlers for a given test-type.
This updates #9558.
|
|
|
|
We need to do this such that we can show all possible results
of a test in the status-page. There might be three back-ends
with different results and if we filter by class-type we'll
be able to see that.
|
|
The new approach uses the redis gems timeout functionality
and ensures we never return a null-job. Instead we timeout
and repeat with a stalling-sleep in the way.
This closes #9553.
|
|
|
|
|
|
As soon as we allow multiple test-implementations we get
into a mess, as Mauve regards an ID as unique and that is
based upon the test-definition not the implementing method
We want to allow:
* HTTPS test to succeed.
* SSL-check to fail.
Which means multiple tests of type "https" will have different
IDs. Force this by adding on the class of the implementation.
|
|
|
|
a given input-line.
|
|
We now work on the assumption that a single "job", pulled from
the queue, might contain multiple "test" objects. These are
the instances of the protocol-testers which we actually execute.
This is part of #9558.
|
|
|
