| Age | Commit message (Collapse) | Author |
|---|
|
We've always had an implicit rule in macro-definitions, that they
end with a period. This meant that the first line is valid:
FOO is bar.vm.bytemark.co.uk.
However we'd expect this to fail:
FOO is bar.vm.bytemark.co.uk
A similar issue would arise if a macro-definition involved more than
one host, only the first would be valid.
We've fixed this now, such that the trailing period is optional.
|
|
This allows better alerting.
|
|
In the past we needed to write:
must run tcp on 3306.
Now we can add the "port" to match the rest of the tests:
must run tcp on port 3306.
|
|
This allows you to write the following (identical) tests:
foo must run FTP.
foo must run ftp.
foo must run FtP.
This is mostly a neatness update.
|
|
This just does a TCP-connection to port 3389.
|
|
If a test fails then we sleep for a small amount of time, two seconds
by default, before repeating it.
This delay is not required for tests that explicitly disable themselves.
|
|
|
|
|
|
|
|
Rather than showing "2, 4, etc" we use the expansion routine
to show TEST_FAILED, TEST_PASSED, etc. This reads more neatly.
|
|
Specifically that we can get the value back as a string, and
work with the ordinal too.
|
|
We no longer test for open-relays so we don't need to run the test.
|
|
This update consists of two changes:
* No longer return "true" or "false" instead return "TEST_FAILED", or "TEST_SUCCEEDED".
* Removed the testing of test-inversion from the class, now it lives in the base-class where it should have done all along.
|
|
|
|
This stops warnings when running with "ruby -w".
|
|
Now tests will no longe return "true" or "false", instead they
will return "TEST_FAILED" or "TEST_PASSED". There is a third
return-value of "TEST_SKIPPED" which essentially ignores a test.
|
|
This commit introduces a major change in custodian. In the past
any test had either two results:
* return false - The test failed.
* return true - The test passed.
We're now using an enum, more or less, such that a test may return a
"skipped" result which will neither raise nor clear any alert(s).
This is useful in its own right but is being introduced specifically
to allow SSL-certificate tests to avoid raising and clearing outside
working days/hours.
This closes #10328.
This fixes #10328.
|
|
We do that with the standard "_"-prefix.
|
|
We've now prefixed our transient/unused variables with "_" to stop
any future errors about variables not being used.
|
|
We'd failed to set the default value of our loaded-marker to false,
although in-practice this wasn't a problem.
|
|
|
|
Due to some sloppy edits this module was not correct.
|
|
|
|
There was a bug in that we used the same local-variable "result"
for two purposes, trashing the intended use-case.
|
|
The Bytemark-specific notifier, using mauve, appends some text to
the bottom of each alert:
http://example.com/ resolves to 1.2.3.4 which is INSIDE|OUTSIDE bytemark
This text was previously limited to the IPv4 address, but now is repeated
for each family which resolves successfully.
This closes #10568.
This fixes #10568.
|
|
|
|
This was failing because '$ERROR_INFO' is only available if
you
require 'English'
|
|
|
|
|
|
|
|
|
|
|
|
These were all identified and suggested by rubocop.
|
|
|
|
|
|
So "foo" is less good than 'foo'.
|
|
|
|
Ruby is not Perl, much as I sometimes wish it were.
|
|
The last expression of a method is the return value. So:
def foo; false ; end
Is the same as:
def foo; return false; end
|
|
So "getURL" becomes "get_url_contents"
|
|
|
|
This is neater. Flagged by rubocop
|
|
Instead use {} + ().
|
|
|
|
This is neater.
|
|
|
|
Instead prefer ".".
Flagged by rubocop
|
|
Having methods take arguments which are ignored is a misleading thing,
prefix with "_" to make that explicit, or remove.
|
|
After raising an exception the following code could not be reached.
|
|
These are not required if the argument is string already, or has
a _to_s method which will be automatically invoked by magic.
|
