summaryrefslogtreecommitdiff
path: root/lib
AgeCommit message (Collapse)Author
2015-08-07Ensure that we correctly parse bogus macro-definitions.Steve Kemp
We've always had an implicit rule in macro-definitions, that they end with a period. This meant that the first line is valid: FOO is bar.vm.bytemark.co.uk. However we'd expect this to fail: FOO is bar.vm.bytemark.co.uk A similar issue would arise if a macro-definition involved more than one host, only the first would be valid. We've fixed this now, such that the trailing period is optional.
2015-08-04Override the alert-test-type for the SSL-expiry check.Steve Kemp
This allows better alerting.
2015-07-29Loosen teh grammar on tcp-tests.Steve Kemp
In the past we needed to write: must run tcp on 3306. Now we can add the "port" to match the rest of the tests: must run tcp on port 3306.
2015-07-29Ensure that protocol-handlers are lower-case.Steve Kemp
This allows you to write the following (identical) tests: foo must run FTP. foo must run ftp. foo must run FtP. This is mostly a neatness update.
2015-07-29Added handler for running RDP-tests.Steve Kemp
This just does a TCP-connection to port 3389.
2015-04-30If a test is skipped we don't need to sleep.Steve Kemp
If a test fails then we sleep for a small amount of time, two seconds by default, before repeating it. This delay is not required for tests that explicitly disable themselves.
2015-04-28Revert the last commit - syslog gives us timestampsSteve Kemp
2015-04-28Show the date/time as well as logged messages.Steve Kemp
2015-04-28Removed temporary debugging putsSteve Kemp
2015-04-24Use the expanded version of our return-codes.Steve Kemp
Rather than showing "2, 4, etc" we use the expansion routine to show TEST_FAILED, TEST_PASSED, etc. This reads more neatly.
2015-04-16Test our enum-like type works as expected.Steve Kemp
Specifically that we can get the value back as a string, and work with the ordinal too.
2015-04-16Removed reference to removed protocol tester.Steve Kemp
We no longer test for open-relays so we don't need to run the test.
2015-04-16Updated test-handler for new API.Steve Kemp
This update consists of two changes: * No longer return "true" or "false" instead return "TEST_FAILED", or "TEST_SUCCEEDED". * Removed the testing of test-inversion from the class, now it lives in the base-class where it should have done all along.
2015-04-16Removed SMTP-relay test entirelySteve Kemp
2015-04-16Mark unused variables with underscore-prefix.Steve Kemp
This stops warnings when running with "ruby -w".
2015-04-16Work with the new return-type from tests.Steve Kemp
Now tests will no longe return "true" or "false", instead they will return "TEST_FAILED" or "TEST_PASSED". There is a third return-value of "TEST_SKIPPED" which essentially ignores a test.
2015-04-16Updated to use types for test-returns.Steve Kemp
This commit introduces a major change in custodian. In the past any test had either two results: * return false - The test failed. * return true - The test passed. We're now using an enum, more or less, such that a test may return a "skipped" result which will neither raise nor clear any alert(s). This is useful in its own right but is being introduced specifically to allow SSL-certificate tests to avoid raising and clearing outside working days/hours. This closes #10328. This fixes #10328.
2015-04-16Mark unused variables as unused.Steve Kemp
We do that with the standard "_"-prefix.
2015-04-16Mark variables as unused.Steve Kemp
We've now prefixed our transient/unused variables with "_" to stop any future errors about variables not being used.
2015-04-16Correctly initialize our state.Steve Kemp
We'd failed to set the default value of our loaded-marker to false, although in-practice this wasn't a problem.
2015-04-16Ensure we load our base-class.Steve Kemp
2015-04-16Fixed to be valid.Steve Kemp
Due to some sloppy edits this module was not correct.
2015-04-16Fixed syntax error.Steve Kemp
2015-04-16Correctly use the result of the resolution in the alert.Steve Kemp
There was a bug in that we used the same local-variable "result" for two purposes, trashing the intended use-case.
2015-04-16Resolve hostnames for both A + AAAA.Steve Kemp
The Bytemark-specific notifier, using mauve, appends some text to the bottom of each alert: http://example.com/ resolves to 1.2.3.4 which is INSIDE|OUTSIDE bytemark This text was previously limited to the IPv4 address, but now is repeated for each family which resolves successfully. This closes #10568. This fixes #10568.
2015-03-10Log the failure-reason on the temporary-fails.Steve Kemp
2015-03-09Show error-message clearly on connection-failure.Steve Kemp
This was failing because '$ERROR_INFO' is only available if you require 'English'
2015-03-09Updated to test for more whitespace issues.Steve Kemp
2015-03-09Removed trailing whitespace from the codeSteve Kemp
2015-03-09Remove spaces inside empty hashesSteve Kemp
2015-03-09Remove spaces inside blocks.Steve Kemp
2015-03-09More minor space fixupsSteve Kemp
2015-03-09Whitespace fixups.Steve Kemp
These were all identified and suggested by rubocop.
2015-03-09Use def with parentheses when there are parameters.Steve Kemp
2015-03-09Removed spaces inside parenthesis.Steve Kemp
2015-03-09Prefer single-quotes when you don't need interpolation.Steve Kemp
So "foo" is less good than 'foo'.
2015-03-09 Prefer single-quoted strings inside interpolations.Steve Kemp
2015-03-09Do not terminate expressions with ";".Steve Kemp
Ruby is not Perl, much as I sometimes wish it were.
2015-03-09Avoid redudent returns.Steve Kemp
The last expression of a method is the return value. So: def foo; false ; end Is the same as: def foo; return false; end
2015-03-09Avoid bogus casing of method-name.Steve Kemp
So "getURL" becomes "get_url_contents"
2015-03-09Don't use parenthesis aroudn conditions in an if.Steve Kemp
2015-03-09Do not use parentheses for method calls with no arguments.Steve Kemp
This is neater. Flagged by rubocop
2015-03-09Avoid "Array.new" and "Hash.new"Steve Kemp
Instead use {} + ().
2015-03-09Removed bogus period.Steve Kemp
2015-03-09Omit the parentheses in defs when the method doesn't accept any arguments.Steve Kemp
This is neater.
2015-03-09Minor indentation fixup.Steve Kemp
2015-03-09Don't use "::" for method-calls.Steve Kemp
Instead prefer ".". Flagged by rubocop
2015-03-09Avoid arguments we're not using.Steve Kemp
Having methods take arguments which are ignored is a misleading thing, prefix with "_" to make that explicit, or remove.
2015-03-09Removed dead code.Steve Kemp
After raising an exception the following code could not be reached.
2015-03-09Avoid redundent ".to_s" methods.Steve Kemp
These are not required if the argument is string already, or has a _to_s method which will be automatically invoked by magic.