Age | Commit message (Collapse) | Author |
|
This involved silencing a few issues that were judged to be minor,
and changing various whitespaces and function-calls. The most
obvious example was changing this:
assert(ret.kind_of? Array)
To this:
assert(ret.kind_of?(Array))
|
|
|
|
These were all identified and suggested by rubocop.
|
|
|
|
So "foo" is less good than 'foo'.
|
|
This is neater. Flagged by rubocop
|
|
This is neater.
|
|
Instead prefer ".".
Flagged by rubocop
|
|
|
|
Broke down the inside? function into a function for returning the hours
in a period, and for sanitizing hour strings "14" vs. "2pm", etc.
Updated test-cases to match.
|
|
parser test, is matching against a period that covers the full
24 hours.
Correctly terminate this case, and add a new test-case to ensure
that this is always correct.
|
|
This means testing values outside the range of 0-23 (inclusive).
We did this already for the start & end times.
This updates #4451.
|
|
This class is used to determine whether an "hour" is within
a given hour-span. e.g. To cope with:
foo must run ping except between 04-06 otherwise 'alert'.
This updates issue #4551.
|