custodian.git - A distributed protocol tester.

Age	Commit message (Collapse)	Author
2017-08-10	Significant rubocop fixups.	Steve Kemp
	This merge-request contains almost entirely mechanical changes, with a few exceptions: * I changed `do_ipv4` and `do_ipv6` to `ipv4` and `ipv6` respectively. * This fixed a warning about normal-casing. * I changed a test-case to compare against both `Integer` and `Fixnum` * Suspect this is a ruby-versionism. The tests continue to pass, so I believe this is safe to merge, but of course it is still not 100%: lib/custodian/queue.rb:135:21: W: Assignment in condition - you probably meant to use ==. added = true ^ lib/custodian/protocoltest/ssl.rb:218:5: W: Do not shadow rescued Exceptions rescue OpenSSL::SSL::SSLError => err ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/custodian/protocoltest/ssl.rb:286:5: W: Do not shadow rescued Exceptions rescue OpenSSL::SSL::SSLError => err ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/custodian/protocoltest/http.rb:307:7: C: Assignment Branch Condition size for run_test is too high. [84.53/72] def run_test ^^^ lib/custodian/protocoltest/http.rb:307:7: C: Cyclomatic complexity for run_test is too high. [22/19] def run_test ^^^ lib/custodian/protocoltest/http.rb:307:7: C: Method has too many lines. [97/87] def run_test ... ^^^^^^^^^^^^ lib/custodian/protocoltest/http.rb:307:7: C: Perceived complexity for run_test is too high. [23/21] def run_test In short this takes care of _most_ of the warnings, but updates requiring significant code-change have not been applied.
2016-04-22	Updated to fix the last remaining rubocop warnings.	Steve Kemp
	This involved silencing a few issues that were judged to be minor, and changing various whitespaces and function-calls. The most obvious example was changing this: assert(ret.kind_of? Array) To this: assert(ret.kind_of?(Array))
2015-03-09	More minor space fixups	Steve Kemp

2015-03-09	Whitespace fixups.	Steve Kemp
	These were all identified and suggested by rubocop.
2015-03-09	Removed spaces inside parenthesis.	Steve Kemp

2015-03-09	Prefer single-quotes when you don't need interpolation.	Steve Kemp
	So "foo" is less good than 'foo'.
2015-03-09	Do not use parentheses for method calls with no arguments.	Steve Kemp
	This is neater. Flagged by rubocop
2015-03-09	Omit the parentheses in defs when the method doesn't accept any arguments.	Steve Kemp
	This is neater.
2015-03-09	Don't use "::" for method-calls.	Steve Kemp
	Instead prefer ".". Flagged by rubocop
2015-01-13	Don't marry our code to ruby1.8	Steve Kemp

2013-06-24	Updated the code to be more module.	Steve Kemp
	Broke down the inside? function into a function for returning the hours in a period, and for sanitizing hour strings "14" vs. "2pm", etc. Updated test-cases to match.
2013-06-24	The worst-case for testing a time-period, and one used in the	Steve Kemp
	parser test, is matching against a period that covers the full 24 hours. Correctly terminate this case, and add a new test-case to ensure that this is always correct.
2013-06-24	Updated the tests to ensure the "current hour" is valid.	Steve Kemp
	This means testing values outside the range of 0-23 (inclusive). We did this already for the start & end times. This updates #4451.
2013-06-24	Added Custodian::Util::TimeSpan	Steve Kemp
	This class is used to determine whether an "hour" is within a given hour-span. e.g. To cope with: foo must run ping except between 04-06 otherwise 'alert'. This updates issue #4551.