| Age | Commit message (Collapse) | Author |
|---|
|
Fixed greedy regex's which would eat much of configuration.
|
|
PR #1437
|
|
Fixed secret regex which would strip config after secret string
(like "privilege 15") and which would not match on:
"bsd-username test secret $1$FAKESTRINGblahblah" which is created
whenever username secret is created.
Added regex to filter password hashes for configs not using
password 7 instead of secret such as:
username test password 7 8888blahblah8888 privilege 4
|
|
|
|
|
|
|
|
pr #1420
|
|
|
|
From issue #1414
|
|
|
|
|
|
|
|
|
|
* reduce no/resolve_repo smell
* reduce input/ssh/connect smell
* reduce source/http load smell
* reduce node/worker smell
* reduce source/csv smell
* reduce output/http smell
Get's code climate from B to A, so I'm sure it's super duper important.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Tested on Netgear M5300's running firmware 10.0.0.53, 11.0.0.23 & 11.0.0.31
|
|
|
|
Scrub uptime in ciscosmb more carefully, closes #1398
|
|
|
|
|
|
Refactor to common login method to ssh/telnet was broken, as common login method made assumptions of expect and cmd API which weren't true for telnet.
telnet.rb updated to resemble ssh.rb API.
|
|
|
|
|
|
Allows cfg, cmd, pre, post and expect blocks to reset the callback array or change from push to unshift.
Use case is in custom models which monkey-patch the distribution model. You might want to replace for example distribution ```cmd :secret``` with your own version, like such:
cmd :secret clear: true do
...
end
Or if you instead want to unshift your block to be first to be called:
cfg :ssh do prepend: true do
..
end
Closes #1384
|
|
|
|
Allow HTTP API to place host array in arbitrary place defined as: hosts_location: a.b[0].c
Also support arrays in mapping keys: key: location[0].is.here[2]
|
|
|
|
|
|
It will always be MAX_SIZE+1 after push
|
|
Store N last mtimes
|
|
|
|
Fixes performance regression
|
|
|
|
* Remove more JunOS secrets
* Removed redundant junos secret replacements. Updated changelog.
* Moved this change to Master in the changelog.
|
|
|
|
So that input/output can be configured under model
|
|
Unsure what problem was being solved here originally, wish I had tests
for expected behaviour :)
|
|
This change works for newer HPE Comware model switches and *shouldn't* cause any issues with the previous Comware models although past functionality hasn't been tested as I don't have an older model.
|
|
Make all the add_* return falsy valuem and make all the callers raise,
this has benefit that the caller has more information, like it can tell
what node we were trying to load when model failed to load.
We were only failing to do this in two places in the code, source and
plugin.
|
|
|
|
Local files could never be loaded, as the name does not contain file
extension, so check for their existance would always fail.
|
|
|
|
Main problem we're trying to solve is the silent failures. Requiring
files will never fail, one user had problem loading their souce http.rb,
which is obviously mandatory for them, but because it didn't fail, it
lead to a much harder to understand bug down the line, as we tried to
instansiate the 'nil' source.
Reason why I did it like this was laziness, because I didn't have to
care if or not the file exists, I always tried to load locally defined
models, and just return empty hash if I couldn't find any.
There may be other reasons and reliances that I've forgotten, but we'll
fix them as they come. Such is life without proper testing.
|
