summaryrefslogtreecommitdiff
path: root/routers/juniper.php
diff options
context:
space:
mode:
authorGuillaume Mazoyer <respawneral@gmail.com>2015-02-09 17:36:09 +0100
committerGuillaume Mazoyer <respawneral@gmail.com>2015-02-09 17:36:09 +0100
commit767174015892dde07a6bc9999e9170b7c21dd378 (patch)
treee1cf636135922d1548168722e73a663636599b5f /routers/juniper.php
parente2172308eec0ee790fe21858ae1c45e72407fa8c (diff)
Fix confusing variable name.
There is only one parameter to check so rename the confusing 'parameters' variable name to 'parameter' accross all the code base.
Diffstat (limited to 'routers/juniper.php')
-rw-r--r--routers/juniper.php24
1 files changed, 12 insertions, 12 deletions
diff --git a/routers/juniper.php b/routers/juniper.php
index 88ea182..a5b4d2d 100644
--- a/routers/juniper.php
+++ b/routers/juniper.php
@@ -58,16 +58,16 @@ final class Juniper extends Router {
return $traceroute;
}
- protected function build_commands($command, $parameters) {
+ protected function build_commands($command, $parameter) {
$commands = array();
switch ($command) {
case 'bgp':
- if (match_ipv4($parameters, false)) {
- $commands[] = 'show route '.$parameters.
+ if (match_ipv4($parameter, false)) {
+ $commands[] = 'show route '.$parameter.
' protocol bgp table inet.0 active-path';
} else if (match_ipv6($parameters, false)) {
- $commands[] = 'show route '.$parameters.
+ $commands[] = 'show route '.$parameter.
' protocol bgp table inet6.0 active-path';
} else {
throw new Exception('The parameter is not an IPv4/IPv6 address.');
@@ -75,10 +75,10 @@ final class Juniper extends Router {
break;
case 'as-path-regex':
- if (match_aspath_regex($parameters)) {
- $commands[] = 'show route aspath-regex "'.$parameters.
+ if (match_aspath_regex($parameter)) {
+ $commands[] = 'show route aspath-regex "'.$parameter.
'" protocol bgp table inet.0';
- $commands[] = 'show route aspath-regex "'.$parameters.
+ $commands[] = 'show route aspath-regex "'.$parameter.
'" protocol bgp table inet6.0';
} else {
throw new Exception('The parameter is not an AS-Path regular expression.');
@@ -86,10 +86,10 @@ final class Juniper extends Router {
break;
case 'as':
- if (match_as($parameters)) {
- $commands[] = 'show route aspath-regex "^'.$parameters.
+ if (match_as($parameter)) {
+ $commands[] = 'show route aspath-regex "^'.$parameter.
' .*" protocol bgp table inet.0';
- $commands[] = 'show route aspath-regex "^'.$parameters.
+ $commands[] = 'show route aspath-regex "^'.$parameter.
' .*" protocol bgp table inet6.0';
} else {
throw new Exception('The parameter is not an AS number.');
@@ -98,7 +98,7 @@ final class Juniper extends Router {
case 'ping':
try {
- $commands[] = $this->build_ping($parameters);
+ $commands[] = $this->build_ping($parameter);
} catch (Exception $e) {
throw $e;
}
@@ -106,7 +106,7 @@ final class Juniper extends Router {
case 'traceroute':
try {
- $commands[] = $this->build_traceroute($parameters);
+ $commands[] = $this->build_traceroute($parameter);
} catch (Exception $e) {
throw $e;
}