Merge pull request #1 from wk/pr-1280

massage into rubocop compliance

1 files changed, 16 insertions, 534 deletions

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 8121015..77c1026 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,19 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-04-11 13:02:45 +0200 using RuboCop version 0.54.0.
+# on 2018-04-25 18:47:11 +0200 using RuboCop version 0.55.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: Include, TreatCommentsAsGroupSeparators.
-# Include: **/*.gemspec
-Gemspec/OrderedDependencies:
-  Exclude:
-    - 'oxidized.gemspec'
-
 # Offense count: 1
 # Configuration parameters: Include.
 # Include: **/*.gemspec
@@ -21,436 +13,13 @@ Gemspec/RequiredRubyVersion:
   Exclude:
     - 'oxidized.gemspec'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: outdent, indent
-Layout/AccessModifierIndentation:
-  Exclude:
-    - 'lib/oxidized/output/gitcrypt.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
-  Exclude:
-    - 'spec/input/ssh_spec.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_parameter, with_fixed_indentation
-Layout/AlignParameters:
-  Exclude:
-    - 'lib/oxidized/hook.rb'
-    - 'lib/oxidized/hook/exec.rb'
-    - 'lib/oxidized/output/git.rb'
-    - 'lib/oxidized/worker.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith.
-# SupportedStylesAlignWith: either, start_of_block, start_of_line
-Layout/BlockAlignment:
-  Exclude:
-    - 'lib/oxidized/model/awplus.rb'
-    - 'lib/oxidized/model/sgos.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Layout/BlockEndNewline:
-  Exclude:
-    - 'lib/oxidized/model/awplus.rb'
-    - 'lib/oxidized/model/hatteras.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
-# SupportedStyles: case, end
-Layout/CaseIndentation:
-  Exclude:
-    - 'lib/oxidized/output/http.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/ClosingParenthesisIndentation:
-  Exclude:
-    - 'lib/oxidized/output/git.rb'
-
-# Offense count: 13
-# Cop supports --auto-correct.
-Layout/CommentIndentation:
-  Exclude:
-    - 'lib/oxidized/model/aosw.rb'
-    - 'lib/oxidized/model/audiocodes.rb'
-    - 'lib/oxidized/model/awplus.rb'
-    - 'lib/oxidized/model/edgeswitch.rb'
-    - 'lib/oxidized/model/fujitsupy.rb'
-    - 'lib/oxidized/model/gcombnps.rb'
-    - 'lib/oxidized/model/masteros.rb'
-    - 'lib/oxidized/model/planet.rb'
-    - 'lib/oxidized/output/http.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
-# SupportedStylesAlignWith: start_of_line, def
-Layout/DefEndAlignment:
-  Exclude:
-    - 'lib/oxidized/hook/xmppdiff.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Layout/ElseAlignment:
-  Exclude:
-    - 'lib/oxidized/input/telnet.rb'
-    - 'lib/oxidized/output/gitcrypt.rb'
-    - 'lib/oxidized/source/csv.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLineAfterMagicComment:
-  Exclude:
-    - 'oxidized.gemspec'
-
-# Offense count: 17
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines.
-Layout/EmptyLineBetweenDefs:
-  Exclude:
-    - 'extra/syslog.rb'
-    - 'lib/oxidized/manager.rb'
-    - 'lib/oxidized/model/model.rb'
-    - 'lib/oxidized/nodes.rb'
-    - 'lib/oxidized/output/git.rb'
-    - 'lib/oxidized/output/gitcrypt.rb'
-
-# Offense count: 17
-# Cop supports --auto-correct.
-Layout/EmptyLines:
-  Exclude:
-    - 'bin/oxidized'
-    - 'lib/oxidized/input/telnet.rb'
-    - 'lib/oxidized/model/acsw.rb'
-    - 'lib/oxidized/model/alvarion.rb'
-    - 'lib/oxidized/model/gaiaos.rb'
-    - 'lib/oxidized/model/gcombnps.rb'
-    - 'lib/oxidized/model/hatteras.rb'
-    - 'lib/oxidized/model/ironware.rb'
-    - 'lib/oxidized/model/planet.rb'
-    - 'lib/oxidized/model/voltaire.rb'
-    - 'lib/oxidized/nodes.rb'
-    - 'lib/oxidized/output/git.rb'
-    - 'lib/oxidized/output/gitcrypt.rb'
-
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, no_empty_lines
-Layout/EmptyLinesAroundBlockBody:
-  Exclude:
-    - 'lib/oxidized/hook/githubrepo.rb'
-    - 'lib/oxidized/model/alvarion.rb'
-    - 'lib/oxidized/model/asyncos.rb'
-    - 'lib/oxidized/model/audiocodes.rb'
-    - 'lib/oxidized/model/ciscosma.rb'
-    - 'lib/oxidized/model/tplink.rb'
-    - 'spec/input/ssh_spec.rb'
-    - 'spec/node_spec.rb'
-
-# Offense count: 158
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
-Layout/EmptyLinesAroundClassBody:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLinesAroundExceptionHandlingKeywords:
-  Exclude:
-    - 'lib/oxidized/hook/exec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLinesAroundMethodBody:
-  Exclude:
-    - 'lib/oxidized/output/http.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
-Layout/EmptyLinesAroundModuleBody:
-  Exclude:
-    - 'lib/oxidized/input/cli.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Layout/EndAlignment:
-  Exclude:
-    - 'lib/oxidized/output/gitcrypt.rb'
-    - 'lib/oxidized/source/csv.rb'
-
-# Offense count: 1
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: native, lf, crlf
-Layout/EndOfLine:
-  Exclude:
-    - 'lib/oxidized/model/br6910.rb'
-
-# Offense count: 63
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
-Layout/FirstParameterIndentation:
-  Exclude:
-    - 'lib/oxidized/output/http.rb'
-
-# Offense count: 11
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_braces
-Layout/IndentHash:
-  Exclude:
-    - 'lib/oxidized/hook/awssns.rb'
-    - 'lib/oxidized/hook/githubrepo.rb'
-    - 'lib/oxidized/input/ssh.rb'
-    - 'lib/oxidized/output/http.rb'
-    - 'spec/githubrepo_spec.rb'
-    - 'spec/node_spec.rb'
-
-# Offense count: 21
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: normal, rails
-Layout/IndentationConsistency:
-  Exclude:
-    - 'lib/oxidized/model/acsw.rb'
-    - 'lib/oxidized/model/awplus.rb'
-    - 'lib/oxidized/model/fortios.rb'
-    - 'lib/oxidized/model/hpebladesystem.rb'
-    - 'lib/oxidized/model/masteros.rb'
-    - 'lib/oxidized/model/sgos.rb'
-    - 'lib/oxidized/model/slxos.rb'
-    - 'lib/oxidized/output/git.rb'
-
-# Offense count: 116
-# Cop supports --auto-correct.
-# Configuration parameters: Width, IgnoredPatterns.
-Layout/IndentationWidth:
-  Enabled: false
-
-# Offense count: 109
-# Cop supports --auto-correct.
-Layout/LeadingCommentSpace:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/MultilineBlockLayout:
-  Exclude:
-    - 'lib/oxidized/model/hatteras.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: symmetrical, new_line, same_line
-Layout/MultilineMethodCallBraceLayout:
-  Exclude:
-    - 'lib/oxidized/hook/slackdiff.rb'
-    - 'lib/oxidized/output/git.rb'
-
-# Offense count: 14
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented
-Layout/MultilineOperationIndentation:
-  Exclude:
-    - 'lib/oxidized/hook.rb'
-    - 'lib/oxidized/model/awplus.rb'
-    - 'lib/oxidized/model/hatteras.rb'
-    - 'lib/oxidized/model/quantaos.rb'
-    - 'lib/oxidized/model/trango.rb'
-
-# Offense count: 33
-# Cop supports --auto-correct.
-Layout/SpaceAfterComma:
-  Enabled: false
-
-# Offense count: 12
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleInsidePipes.
-# SupportedStylesInsidePipes: space, no_space
-Layout/SpaceAroundBlockParameters:
-  Exclude:
-    - 'lib/oxidized/model/aos.rb'
-    - 'lib/oxidized/model/aos7.rb'
-    - 'lib/oxidized/model/c4cmts.rb'
-    - 'lib/oxidized/model/coriantgroove.rb'
-    - 'lib/oxidized/model/dlink.rb'
-    - 'lib/oxidized/model/enterasys.rb'
-    - 'lib/oxidized/model/hpebladesystem.rb'
-    - 'lib/oxidized/model/mtrlrfs.rb'
-    - 'lib/oxidized/model/xos.rb'
-    - 'lib/oxidized/model/zhoneolt.rb'
-    - 'lib/oxidized/node.rb'
-
-# Offense count: 32
-# Cop supports --auto-correct.
-# Configuration parameters: .
-# SupportedStyles: space, no_space
-Layout/SpaceAroundEqualsInParameterDefault:
-  EnforcedStyle: no_space
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/SpaceAroundKeyword:
-  Exclude:
-    - 'lib/oxidized/input/telnet.rb'
-    - 'lib/oxidized/model/xos.rb'
-
-# Offense count: 49
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
-Layout/SpaceAroundOperators:
-  Enabled: false
-
-# Offense count: 15
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceBeforeBlockBraces:
-  Exclude:
-    - 'lib/oxidized/cli.rb'
-    - 'lib/oxidized/model/aos.rb'
-    - 'lib/oxidized/model/aos7.rb'
-    - 'lib/oxidized/model/c4cmts.rb'
-    - 'lib/oxidized/model/coriantgroove.rb'
-    - 'lib/oxidized/model/dlink.rb'
-    - 'lib/oxidized/model/enterasys.rb'
-    - 'lib/oxidized/model/hpebladesystem.rb'
-    - 'lib/oxidized/model/mtrlrfs.rb'
-    - 'lib/oxidized/model/xos.rb'
-    - 'lib/oxidized/model/zhoneolt.rb'
-    - 'lib/oxidized/node.rb'
-    - 'lib/oxidized/output/output.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-Layout/SpaceBeforeComma:
-  Exclude:
-    - 'lib/oxidized/hook/exec.rb'
-    - 'lib/oxidized/model/fortios.rb'
-
-# Offense count: 25
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
-Layout/SpaceBeforeFirstArg:
-  Enabled: false
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBrackets: space, no_space
-Layout/SpaceInsideArrayLiteralBrackets:
-  Exclude:
-    - 'lib/oxidized/input/ssh.rb'
-    - 'lib/oxidized/input/telnet.rb'
-    - 'oxidized.gemspec'
-
-# Offense count: 31
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideBlockBraces:
-  Enabled: false
-
-# Offense count: 23
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideHashLiteralBraces:
-  Exclude:
-    - 'lib/oxidized/hook/slackdiff.rb'
-    - 'lib/oxidized/output/git.rb'
-    - 'lib/oxidized/output/gitcrypt.rb'
-    - 'lib/oxidized/output/http.rb'
-    - 'spec/githubrepo_spec.rb'
-    - 'spec/input/ssh_spec.rb'
-
-# Offense count: 9
-# Cop supports --auto-correct.
-Layout/SpaceInsideParens:
-  Exclude:
-    - 'extra/syslog.rb'
-    - 'lib/oxidized/input/telnet.rb'
-    - 'lib/oxidized/model/asa.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-Layout/SpaceInsidePercentLiteralDelimiters:
-  Exclude:
-    - 'oxidized.gemspec'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-Layout/SpaceInsideRangeLiteral:
-  Exclude:
-    - 'lib/oxidized/input/telnet.rb'
-
-# Offense count: 302
-# Cop supports --auto-correct.
-# Configuration parameters: IndentationWidth.
-Layout/Tab:
-  Exclude:
-    - 'lib/oxidized/model/asyncos.rb'
-    - 'lib/oxidized/model/ciscosma.rb'
-    - 'lib/oxidized/model/cumulus.rb'
-    - 'lib/oxidized/output/gitcrypt.rb'
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: final_newline, final_blank_line
-Layout/TrailingBlankLines:
-  Exclude:
-    - 'lib/oxidized/model/aen.rb'
-    - 'lib/oxidized/model/apc_aos.rb'
-    - 'lib/oxidized/model/firewareos.rb'
-    - 'lib/oxidized/model/gcombnps.rb'
-    - 'lib/oxidized/model/hpemsa.rb'
-    - 'lib/oxidized/model/mtrlrfs.rb'
-    - 'lib/oxidized/model/tplink.rb'
-    - 'lib/oxidized/output/http.rb'
-
-# Offense count: 165
-# Cop supports --auto-correct.
-Layout/TrailingWhitespace:
-  Enabled: false
-
 # Offense count: 4
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'lib/oxidized/model/model.rb'
     - 'lib/oxidized/model/nos.rb'
 
-# Offense count: 648
+# Offense count: 652
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
@@ -499,13 +68,6 @@ Lint/ShadowingOuterLocalVariable:
     - 'lib/oxidized/model/fortios.rb'
     - 'lib/oxidized/model/planet.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-Lint/StringConversionInInterpolation:
-  Exclude:
-    - 'lib/oxidized/hook/slackdiff.rb'
-    - 'lib/oxidized/hook/xmppdiff.rb'
-
 # Offense count: 10
 Lint/UnderscorePrefixedVariableName:
   Exclude:
@@ -554,14 +116,14 @@ Lint/Void:
 
 # Offense count: 60
 Metrics/AbcSize:
-  Max: 86
+  Max: 84
 
 # Offense count: 15
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 143
+  Max: 142
 
-# Offense count: 4
+# Offense count: 2
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 4
@@ -629,7 +191,7 @@ Naming/PredicateName:
 
 # Offense count: 11
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to
+# AllowedNames: io, id, to, by, on, in, at
 Naming/UncommunicativeMethodParamName:
   Exclude:
     - 'extra/syslog.rb'
@@ -701,13 +263,7 @@ Style/Alias:
 Style/AndOr:
   Enabled: false
 
-# Offense count: 1
-# Configuration parameters: AllowedChars.
-Style/AsciiComments:
-  Exclude:
-    - 'lib/oxidized/hook/slackdiff.rb'
-
-# Offense count: 4
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods.
 # SupportedStyles: line_count_based, semantic, braces_for_chaining
@@ -716,24 +272,19 @@ Style/AsciiComments:
 # IgnoredMethods: lambda, proc, it
 Style/BlockDelimiters:
   Exclude:
-    - 'lib/oxidized/hook/xmppdiff.rb'
     - 'lib/oxidized/model/aricentiss.rb'
     - 'lib/oxidized/model/hatteras.rb'
 
-# Offense count: 12
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: braces, no_braces, context_dependent
 Style/BracesAroundHashParameters:
   Exclude:
-    - 'lib/oxidized/hook/awssns.rb'
     - 'lib/oxidized/hook/githubrepo.rb'
     - 'lib/oxidized/input/telnet.rb'
     - 'lib/oxidized/model/procurve.rb'
     - 'lib/oxidized/output/http.rb'
-    - 'spec/githubrepo_spec.rb'
-    - 'spec/input/ssh_spec.rb'
-    - 'spec/node_spec.rb'
 
 # Offense count: 3
 Style/CaseEquality:
@@ -764,11 +315,10 @@ Style/ClassVars:
   Exclude:
     - 'lib/oxidized.rb'
 
-# Offense count: 5
+# Offense count: 4
 # Cop supports --auto-correct.
 Style/ColonMethodCall:
   Exclude:
-    - 'lib/oxidized/hook/xmppdiff.rb'
     - 'lib/oxidized/input/ssh.rb'
     - 'lib/oxidized/input/telnet.rb'
 
@@ -786,7 +336,7 @@ Style/ConditionalAssignment:
     - 'lib/oxidized/hook/githubrepo.rb'
     - 'lib/oxidized/model/model.rb'
 
-# Offense count: 142
+# Offense count: 144
 Style/Documentation:
   Enabled: false
 
@@ -806,42 +356,15 @@ Style/EmptyMethod:
 
 # Offense count: 1
 # Cop supports --auto-correct.
-Style/Encoding:
-  Exclude:
-    - 'oxidized.gemspec'
-
-# Offense count: 2
-# Cop supports --auto-correct.
 Style/ExpandPathArguments:
   Exclude:
     - 'bin/console'
-    - 'oxidized.gemspec'
 
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: format, sprintf, percent
-Style/FormatString:
-  Exclude:
-    - 'lib/oxidized/hook/slackdiff.rb'
-    - 'lib/oxidized/node.rb'
-    - 'lib/oxidized/nodes.rb'
-
-# Offense count: 16
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: annotated, template, unannotated
-Style/FormatStringToken:
-  Exclude:
-    - 'lib/oxidized/node.rb'
-    - 'lib/oxidized/nodes.rb'
-
-# Offense count: 15
+# Offense count: 13
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
     - 'lib/oxidized/cli.rb'
-    - 'lib/oxidized/hook/slackdiff.rb'
-    - 'lib/oxidized/hook/xmppdiff.rb'
     - 'lib/oxidized/input/cli.rb'
     - 'lib/oxidized/jobs.rb'
     - 'lib/oxidized/nodes.rb'
@@ -865,7 +388,7 @@ Style/IfInsideElse:
   Exclude:
     - 'lib/oxidized/output/file.rb'
 
-# Offense count: 38
+# Offense count: 39
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Enabled: false
@@ -882,34 +405,12 @@ Style/InfiniteLoop:
     - 'extra/syslog.rb'
     - 'lib/oxidized/core.rb'
 
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: InverseMethods, InverseBlocks.
-Style/InverseMethods:
-  Exclude:
-    - 'lib/oxidized/model/aosw.rb'
-    - 'lib/oxidized/model/asa.rb'
-    - 'lib/oxidized/model/comware.rb'
-    - 'lib/oxidized/model/firewareos.rb'
-    - 'lib/oxidized/model/powerconnect.rb'
-    - 'lib/oxidized/model/procurve.rb'
-    - 'lib/oxidized/model/routeros.rb'
-    - 'lib/oxidized/model/vrp.rb'
-    - 'lib/oxidized/model/zhoneolt.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/LineEndConcatenation:
   Exclude:
     - 'lib/oxidized/hook.rb'
 
-# Offense count: 9
-# Cop supports --auto-correct.
-Style/MethodCallWithoutArgsParentheses:
-  Exclude:
-    - 'spec/githubrepo_spec.rb'
-    - 'spec/input/ssh_spec.rb'
-
 # Offense count: 131
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
@@ -923,7 +424,7 @@ Style/MultilineIfThen:
   Exclude:
     - 'lib/oxidized/model/aricentiss.rb'
 
-# Offense count: 8
+# Offense count: 9
 # Cop supports --auto-correct.
 Style/MutableConstant:
   Exclude:
@@ -962,11 +463,6 @@ Style/NilComparison:
   Exclude:
     - 'lib/oxidized/input/ssh.rb'
 
-# Offense count: 31
-# Cop supports --auto-correct.
-Style/Not:
-  Enabled: false
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedOctalStyle.
@@ -1013,15 +509,13 @@ Style/ParenthesesAroundCondition:
     - 'lib/oxidized/model/powerconnect.rb'
     - 'lib/oxidized/source/http.rb'
 
-# Offense count: 10
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
     - 'lib/oxidized/config.rb'
     - 'lib/oxidized/input/ssh.rb'
-    - 'oxidized.gemspec'
-    - 'spec/nodes_spec.rb'
 
 # Offense count: 22
 # Cop supports --auto-correct.
@@ -1033,17 +527,6 @@ Style/PerlBackrefs:
     - 'lib/oxidized/model/junos.rb'
     - 'lib/oxidized/model/powerconnect.rb'
 
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: short, verbose
-Style/PreferredHashMethods:
-  Exclude:
-    - 'lib/oxidized/manager.rb'
-    - 'lib/oxidized/source/csv.rb'
-    - 'lib/oxidized/source/http.rb'
-    - 'lib/oxidized/source/sql.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/Proc:
@@ -1191,14 +674,13 @@ Style/TrailingCommaInHashLiteral:
     - 'lib/oxidized/node.rb'
     - 'lib/oxidized/node/stats.rb'
 
-# Offense count: 3
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: AllowNamedUnderscoreVariables.
 Style/TrailingUnderscoreVariable:
   Exclude:
     - 'lib/oxidized/node.rb'
     - 'lib/oxidized/output/git.rb'
-    - 'spec/node_spec.rb'
 
 # Offense count: 3
 # Cop supports --auto-correct.
@@ -1234,7 +716,7 @@ Style/ZeroLengthPredicate:
     - 'lib/oxidized/model/ciscosmb.rb'
     - 'lib/oxidized/output/git.rb'
 
-# Offense count: 275
+# Offense count: 270
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength: