Merge pull request #1293 from wk/bump-rubocop

bump rubocop to 0.55 and regenerate .rubocop_todo.yml

3 files changed, 46 insertions, 38 deletions

diff --git a/.rubocop.yml b/.rubocop.yml
index ad1ca31..bc013cd 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -14,6 +14,9 @@ LineLength:
 Style/PreferredHashMethods:
   EnforcedStyle: verbose
 
+Style/Not:
+  Enabled: false
+
 AllCops:
   Exclude:
     - 'vendor/**/*'
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a56def7..b91409a 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-04-11 13:02:45 +0200 using RuboCop version 0.54.0.
+# on 2018-04-20 14:46:50 +0200 using RuboCop version 0.55.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -21,14 +21,6 @@ Gemspec/RequiredRubyVersion:
   Exclude:
     - 'oxidized.gemspec'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: outdent, indent
-Layout/AccessModifierIndentation:
-  Exclude:
-    - 'lib/oxidized/output/gitcrypt.rb'
-
 # Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
@@ -128,7 +120,7 @@ Layout/EmptyLines:
     - 'lib/oxidized/output/git.rb'
     - 'lib/oxidized/output/gitcrypt.rb'
 
-# Offense count: 9
+# Offense count: 7
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, no_empty_lines
@@ -141,7 +133,7 @@ Layout/EmptyLinesAroundBlockBody:
     - 'lib/oxidized/model/ciscosma.rb'
     - 'lib/oxidized/model/tplink.rb'
 
-# Offense count: 158
+# Offense count: 159
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
@@ -198,7 +190,7 @@ Layout/FirstParameterIndentation:
   Exclude:
     - 'lib/oxidized/output/http.rb'
 
-# Offense count: 11
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_braces
@@ -223,13 +215,13 @@ Layout/IndentationConsistency:
     - 'lib/oxidized/model/slxos.rb'
     - 'lib/oxidized/output/git.rb'
 
-# Offense count: 116
+# Offense count: 47
 # Cop supports --auto-correct.
 # Configuration parameters: Width, IgnoredPatterns.
 Layout/IndentationWidth:
   Enabled: false
 
-# Offense count: 109
+# Offense count: 108
 # Cop supports --auto-correct.
 Layout/LeadingCommentSpace:
   Enabled: false
@@ -240,7 +232,7 @@ Layout/MultilineBlockLayout:
   Exclude:
     - 'lib/oxidized/model/hatteras.rb'
 
-# Offense count: 2
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
@@ -348,15 +340,30 @@ Layout/SpaceInsideArrayLiteralBrackets:
     - 'lib/oxidized/input/telnet.rb'
     - 'oxidized.gemspec'
 
-# Offense count: 31
+# Offense count: 29
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
 # SupportedStyles: space, no_space
 # SupportedStylesForEmptyBraces: space, no_space
 Layout/SpaceInsideBlockBraces:
-  Enabled: false
+  Exclude:
+    - 'lib/oxidized/cli.rb'
+    - 'lib/oxidized/hook.rb'
+    - 'lib/oxidized/model/aos.rb'
+    - 'lib/oxidized/model/aos7.rb'
+    - 'lib/oxidized/model/c4cmts.rb'
+    - 'lib/oxidized/model/coriantgroove.rb'
+    - 'lib/oxidized/model/dlink.rb'
+    - 'lib/oxidized/model/enterasys.rb'
+    - 'lib/oxidized/model/fabricos.rb'
+    - 'lib/oxidized/model/hpebladesystem.rb'
+    - 'lib/oxidized/model/mtrlrfs.rb'
+    - 'lib/oxidized/model/xos.rb'
+    - 'lib/oxidized/model/zhoneolt.rb'
+    - 'lib/oxidized/node.rb'
+    - 'lib/oxidized/nodes.rb'
 
-# Offense count: 23
+# Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space, compact
@@ -369,6 +376,8 @@ Layout/SpaceInsideHashLiteralBraces:
 
 # Offense count: 9
 # Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: space, no_space
 Layout/SpaceInsideParens:
   Exclude:
     - 'extra/syslog.rb'
@@ -402,8 +411,9 @@ Layout/TrailingBlankLines:
     - 'lib/oxidized/model/tplink.rb'
     - 'lib/oxidized/output/http.rb'
 
-# Offense count: 165
+# Offense count: 179
 # Cop supports --auto-correct.
+# Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Enabled: false
 
@@ -413,7 +423,7 @@ Lint/AmbiguousBlockAssociation:
     - 'lib/oxidized/model/model.rb'
     - 'lib/oxidized/model/nos.rb'
 
-# Offense count: 648
+# Offense count: 652
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
@@ -510,14 +520,14 @@ Lint/Void:
 
 # Offense count: 60
 Metrics/AbcSize:
-  Max: 86
+  Max: 84
 
 # Offense count: 15
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 143
+  Max: 142
 
-# Offense count: 4
+# Offense count: 2
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 4
@@ -585,7 +595,7 @@ Naming/PredicateName:
 
 # Offense count: 11
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to
+# AllowedNames: io, id, to, by, on, in, at
 Naming/UncommunicativeMethodParamName:
   Exclude:
     - 'extra/syslog.rb'
@@ -657,7 +667,7 @@ Style/Alias:
 Style/AndOr:
   Enabled: false
 
-# Offense count: 4
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods.
 # SupportedStyles: line_count_based, semantic, braces_for_chaining
@@ -669,7 +679,7 @@ Style/BlockDelimiters:
     - 'lib/oxidized/model/aricentiss.rb'
     - 'lib/oxidized/model/hatteras.rb'
 
-# Offense count: 12
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: braces, no_braces, context_dependent
@@ -709,7 +719,7 @@ Style/ClassVars:
   Exclude:
     - 'lib/oxidized.rb'
 
-# Offense count: 5
+# Offense count: 4
 # Cop supports --auto-correct.
 Style/ColonMethodCall:
   Exclude:
@@ -730,7 +740,7 @@ Style/ConditionalAssignment:
     - 'lib/oxidized/hook/githubrepo.rb'
     - 'lib/oxidized/model/model.rb'
 
-# Offense count: 142
+# Offense count: 143
 Style/Documentation:
   Enabled: false
 
@@ -761,7 +771,7 @@ Style/ExpandPathArguments:
     - 'bin/console'
     - 'oxidized.gemspec'
 
-# Offense count: 7
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: format, sprintf, percent
@@ -778,7 +788,7 @@ Style/FormatStringToken:
     - 'lib/oxidized/node.rb'
     - 'lib/oxidized/nodes.rb'
 
-# Offense count: 15
+# Offense count: 13
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
@@ -881,11 +891,6 @@ Style/NilComparison:
   Exclude:
     - 'lib/oxidized/input/ssh.rb'
 
-# Offense count: 31
-# Cop supports --auto-correct.
-Style/Not:
-  Enabled: false
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedOctalStyle.
@@ -932,7 +937,7 @@ Style/ParenthesesAroundCondition:
     - 'lib/oxidized/model/powerconnect.rb'
     - 'lib/oxidized/source/http.rb'
 
-# Offense count: 10
+# Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -1098,7 +1103,7 @@ Style/TrailingCommaInHashLiteral:
     - 'lib/oxidized/node.rb'
     - 'lib/oxidized/node/stats.rb'
 
-# Offense count: 3
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: AllowNamedUnderscoreVariables.
 Style/TrailingUnderscoreVariable:
diff --git a/oxidized.gemspec b/oxidized.gemspec
index 6019842..dfcaf4c 100644
--- a/oxidized.gemspec
+++ b/oxidized.gemspec
@@ -34,6 +34,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'minitest', '~> 5.8'
   s.add_development_dependency 'mocha',    '~> 1.1'
   s.add_development_dependency 'git',      '~> 1'
-  s.add_development_dependency 'rubocop',  '~> 0.54'
+  s.add_development_dependency 'rubocop',  '~> 0.55.0'
   s.add_development_dependency 'rails_best_practices', '~> 1.19'
 end