summaryrefslogtreecommitdiff
path: root/lib/oxidized/model
diff options
context:
space:
mode:
authorSaku Ytti <saku@ytti.fi>2018-06-07 10:08:44 +0300
committerSaku Ytti <saku@ytti.fi>2018-06-07 10:08:44 +0300
commitea181e93f90ada5d74921cab7ba89e308b9ea1e3 (patch)
tree25cbd4a3c19ca79cfe2de817452e007424ca4b57 /lib/oxidized/model
parent5cfdbaa959b86d2c8e65963a828ab309302c9020 (diff)
Refactor manager
Main problem we're trying to solve is the silent failures. Requiring files will never fail, one user had problem loading their souce http.rb, which is obviously mandatory for them, but because it didn't fail, it lead to a much harder to understand bug down the line, as we tried to instansiate the 'nil' source. Reason why I did it like this was laziness, because I didn't have to care if or not the file exists, I always tried to load locally defined models, and just return empty hash if I couldn't find any. There may be other reasons and reliances that I've forgotten, but we'll fix them as they come. Such is life without proper testing.
Diffstat (limited to 'lib/oxidized/model')
0 files changed, 0 insertions, 0 deletions